Improve tmp iterator variable name for convert_for_to_while_let#20979
Open
A4-Tacks wants to merge 1 commit intorust-lang:masterfrom
Open
Improve tmp iterator variable name for convert_for_to_while_let#20979A4-Tacks wants to merge 1 commit intorust-lang:masterfrom
A4-Tacks wants to merge 1 commit intorust-lang:masterfrom
Conversation
Example
---
```rust
fn main() {
let x = vec![1, 2, 3];
for$0 v in x {
let y = v * 2;
};
}
```
**Before this PR**
```rust
fn main() {
let x = vec![1, 2, 3];
let mut tmp = x.into_iter();
while let Some(v) = tmp.next() {
let y = v * 2;
};
}
```
**After this PR**
```rust
fn main() {
let x = vec![1, 2, 3];
let mut iter = x.into_iter();
while let Some(v) = iter.next() {
let y = v * 2;
};
}
```
41 tasks
ChayimFriedman2
approved these changes
Mar 22, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Example
Before this PR
After this PR