Support WhileExpr and ForExpr for add_label_to_loop#20984
Merged
ChayimFriedman2 merged 1 commit intorust-lang:masterfrom Mar 22, 2026
Merged
Support WhileExpr and ForExpr for add_label_to_loop#20984ChayimFriedman2 merged 1 commit intorust-lang:masterfrom
ChayimFriedman2 merged 1 commit intorust-lang:masterfrom
Conversation
rustbot
added
the
S-waiting-on-review
41 tasks
A4-Tacks
force-pushed
the
add-label-while-for
branch
2 times, most recently
from
cfbd307 to
9722385
Compare
Veykril
reviewed
Nov 23, 2025
crates/syntax/src/ast/node_ext.rs
Outdated
|
|
||
| impl HasAttrs for TypeOrConstParam {} | ||
|
|
||
| pub enum LoopLike { |
Member
There was a problem hiding this comment.
We don;t need this I believe, we can use the AnyHasLoopBody node instead which should cover all loop types
Member
Author
There was a problem hiding this comment.
Because loop_expr.loop_token() is needed, AnyHasLoopBody will be more inconvenient, or should I add methods to AnyHasLoopBody?
Example
---
```rust
fn main() {
for$0 _ in 0..5 {
break;
continue;
}
}
```
**Before this PR**
Assist not applicable
**After this PR**
```rust
fn main() {
'l: for _ in 0..5 {
break 'l;
continue 'l;
}
}
```
A4-Tacks
force-pushed
the
add-label-while-for
branch
from
9722385 to
9a99201
Compare
ChayimFriedman2
approved these changes
Mar 22, 2026
rustbot
removed
the
S-waiting-on-review
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Example
Before this PR
Assist not applicable
After this PR