Merged
Conversation
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR aims at uplifting the
clippy::cmp_nanlint into rustc.invalid_nan_comparisons(deny-by-default)(warn-by-default)The
invalid_nan_comparisonslint checks comparison withf32::NANorf64::NANas one of the operand.Example
Explanation
NaN does not compare meaningfully to anything – not even itself – so those comparisons are always false.
Mostly followed the instructions for uplifting a clippy lint described here: #99696 (review)
@rustbot label: +I-lang-nominated
r? compiler