match lowering: Introduce a TestCase enum to replace most matching on PatKind#121393
Merged
bors merged 4 commits intorust-lang:masterfrom Feb 22, 2024
Merged
match lowering: Introduce a TestCase enum to replace most matching on PatKind#121393bors merged 4 commits intorust-lang:masterfrom
TestCase enum to replace most matching on PatKind#121393bors merged 4 commits intorust-lang:masterfrom
Conversation
Loading
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Introduces
TestCasethat represents the specific outcome of a test. It complementsTestKindwhich represents a test. InMatchPair::new()we select the appropriateTestCasefor the pattern, and after that we almost never have to inspect the pattern directly during match lowering.Together with #120904, this makes
MatchPairinto a standalone abstraction that hides the details ofthir::Pat. This will become even truer in the next PR where I makeTestCasehandle or patterns. This opens the door to a lot of future simplifications.r? @matthewjasper