Skip to content

Add APIs for dealing with titlecase#122668

Open
Jules-Bertholet wants to merge 3 commits intorust-lang:mainfrom
Jules-Bertholet:titlecase
Open

Add APIs for dealing with titlecase#122668
Jules-Bertholet wants to merge 3 commits intorust-lang:mainfrom
Jules-Bertholet:titlecase

Conversation

@Jules-Bertholet
Copy link
Contributor

@Jules-Bertholet Jules-Bertholet commented Mar 17, 2024

View all comments

ACP: rust-lang/libs-team#354
Tracking issue: #153892

r? libs-api

@rustbot label T-libs -T-libs-api A-unicode

The last commit has some insta-stable PartialEq impls, therefore: @rustbot label -needs-fcp
Alternatively, I could split those out into a follow-up PR.
(Edit: will do in follow-up)

@rustbot rustbot added S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. T-libs Relevant to the library team, which will review and decide on the PR/issue. A-Unicode Area: Unicode S-waiting-on-ACP Status: PR has an ACP and is waiting for the ACP to complete. T-libs-api Relevant to the library API team, which will review and decide on the PR/issue. labels Mar 17, 2024
@bors
Copy link
Collaborator

bors commented Mar 29, 2024

☔ The latest upstream changes (presumably #122616) made this pull request unmergeable. Please resolve the merge conflicts.

@bors
Copy link
Collaborator

bors commented Apr 20, 2024

☔ The latest upstream changes (presumably #122013) made this pull request unmergeable. Please resolve the merge conflicts.

@Dylan-DPC Dylan-DPC removed the S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. label May 3, 2024
@rustbot
Copy link
Collaborator

rustbot commented Nov 24, 2025

library/core/src/unicode/unicode_data.rs is generated by the src/tools/unicode-table-generator tool.

If you want to modify unicode_data.rs, please modify the tool then regenerate the library source file via ./x run src/tools/unicode-table-generator instead of editing unicode_data.rs manually.

@rustbot

This comment has been minimized.

@Jules-Bertholet
Copy link
Contributor Author

Jules-Bertholet commented Nov 24, 2025

The libs team gave a positive response to the ACP. @rustbot label -S-waiting-on-ACP S-waiting-on-review

@rustbot rustbot added S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. needs-fcp This change is insta-stable, or significant enough to need a team FCP to proceed. and removed S-waiting-on-ACP Status: PR has an ACP and is waiting for the ACP to complete. labels Nov 24, 2025
@rust-bors

This comment has been minimized.

@rustbot

This comment has been minimized.

@rust-bors

This comment has been minimized.

@rustbot
Copy link
Collaborator

rustbot commented Mar 15, 2026

This PR was rebased onto a different main commit. Here's a range-diff highlighting what actually changed.

Rebasing is a normal part of keeping PRs up to date, so no action is needed—this note is just to help reviewers.

@rustbot rustbot removed the needs-fcp This change is insta-stable, or significant enough to need a team FCP to proceed. label Mar 15, 2026
@rustbot rustbot removed the T-libs-api Relevant to the library API team, which will review and decide on the PR/issue. label Mar 15, 2026
@Jules-Bertholet
Copy link
Contributor Author

@rustbot reroll

@rust-bors
Copy link
Contributor

rust-bors bot commented Mar 22, 2026

💥 Test timed out after 21600s

@rust-bors rust-bors bot added the S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. label Mar 22, 2026
@JonathanBrouwer
Copy link
Contributor

Let's see if that's reproducible
@bors try jobs=x86_64-gnu-aux

@rust-bors
Copy link
Contributor

rust-bors bot commented Mar 22, 2026

❌ Encountered an error while executing command

@JonathanBrouwer
Copy link
Contributor

........
@bors try jobs=x86_64-gnu-aux

@rust-bors

This comment has been minimized.

rust-bors bot pushed a commit that referenced this pull request Mar 22, 2026
Add APIs for dealing with titlecase


try-job: x86_64-gnu-aux
rust-bors bot pushed a commit that referenced this pull request Mar 23, 2026
…uwer

Rollup of 22 pull requests

Successful merges:

 - #122668 (Add APIs for dealing with titlecase)
 - #152543 (privacy: Fix type privacy holes in RPITITs)
 - #153107 (Optimize BTreeMap::append() using CursorMut)
 - #153312 (Packages as namespaces part 1)
 - #153534 (Remove a flaky `got_timeout` assert from two channel tests)
 - #153718 (Fix environ on FreeBSD with cdylib targets that use -Wl,--no-undefined .)
 - #153857 (Rename `target.abi` to `target.cfg_abi` and enum-ify llvm_abiname)
 - #153880 (Lifted intersperse and intersperse_with Fused transformation and updated documentation + tests)
 - #153931 (remove usages of to-be-deprecated numeric constants)
 - #150630 (Unknown -> Unsupported compression algorithm)
 - #153491 (Move `freeze_*` methods to `OpenOptionsExt2`)
 - #153582 (Simplify find_attr! for HirId usage)
 - #153623 (std: move `sys::pal::os` to `sys::paths`)
 - #153647 (docs(fs): Clarify That File::lock Coordinates Across Processes)
 - #153936 (Skip stack_start_aligned for immediate-abort)
 - #154011 (implement `BinaryHeap::as_mut_slice`)
 - #154167 (ui/lto: move and rename two tests from issues/)
 - #154174 (allow `incomplete_features` in most UI tests)
 - #154175 (Add new alias for Guillaume Gomez email address)
 - #154182 (diagnostics: avoid ICE for undeclared generic parameter in impl)
 - #154188 (Update the tracking issue for #[diagnostic::on_move])
 - #154201 (Use enums to clarify `DepNodeColorMap` color marking )
@rust-bors
Copy link
Contributor

rust-bors bot commented Mar 23, 2026

💔 Test for 71a9f36 failed: CI

rust-bors bot pushed a commit that referenced this pull request Mar 23, 2026
…uwer

Rollup of 22 pull requests

Successful merges:

 - #122668 (Add APIs for dealing with titlecase)
 - #152543 (privacy: Fix type privacy holes in RPITITs)
 - #153107 (Optimize BTreeMap::append() using CursorMut)
 - #153312 (Packages as namespaces part 1)
 - #153534 (Remove a flaky `got_timeout` assert from two channel tests)
 - #153718 (Fix environ on FreeBSD with cdylib targets that use -Wl,--no-undefined .)
 - #153857 (Rename `target.abi` to `target.cfg_abi` and enum-ify llvm_abiname)
 - #153880 (Lifted intersperse and intersperse_with Fused transformation and updated documentation + tests)
 - #153931 (remove usages of to-be-deprecated numeric constants)
 - #150630 (Unknown -> Unsupported compression algorithm)
 - #153491 (Move `freeze_*` methods to `OpenOptionsExt2`)
 - #153582 (Simplify find_attr! for HirId usage)
 - #153623 (std: move `sys::pal::os` to `sys::paths`)
 - #153647 (docs(fs): Clarify That File::lock Coordinates Across Processes)
 - #153936 (Skip stack_start_aligned for immediate-abort)
 - #154011 (implement `BinaryHeap::as_mut_slice`)
 - #154167 (ui/lto: move and rename two tests from issues/)
 - #154174 (allow `incomplete_features` in most UI tests)
 - #154175 (Add new alias for Guillaume Gomez email address)
 - #154182 (diagnostics: avoid ICE for undeclared generic parameter in impl)
 - #154188 (Update the tracking issue for #[diagnostic::on_move])
 - #154201 (Use enums to clarify `DepNodeColorMap` color marking )
@JonathanBrouwer
Copy link
Contributor

@bors r-
The tests added by this PR seem to be very slow


Mon, 23 Mar 2026 00:51:27 GMT   test cell::refcell_replace ... ok
Mon, 23 Mar 2026 00:51:28 GMT   test cell::refcell_replace_borrows ... ok
Mon, 23 Mar 2026 00:51:28 GMT   test cell::refcell_swap ... ok
Mon, 23 Mar 2026 00:51:28 GMT   test cell::refcell_swap_borrows ... ok
Mon, 23 Mar 2026 00:51:28 GMT   test cell::refcell_unsized ... ok
Mon, 23 Mar 2026 00:51:28 GMT   test cell::smoketest_cell ... ok
Mon, 23 Mar 2026 00:51:29 GMT   test cell::smoketest_unsafe_cell ... ok
Mon, 23 Mar 2026 00:51:29 GMT   test cell::unsafe_cell_raw_get ... ok
Mon, 23 Mar 2026 00:51:29 GMT   test cell::unsafe_cell_unsized ... ok
Mon, 23 Mar 2026 02:55:12 GMT   test char::at_most_one_case ... ok
Mon, 23 Mar 2026 02:55:12 GMT   test char::ed_iterator_specializations ... ok
Mon, 23 Mar 2026 02:55:12 GMT   test char::eu_iterator_specializations ... ok
Mon, 23 Mar 2026 02:55:12 GMT   test char::test_as_ascii_invalid ... ok
Mon, 23 Mar 2026 04:55:46 GMT   test char::test_char_case ... ok
Mon, 23 Mar 2026 04:55:46 GMT   test char::test_convert ... ok
Mon, 23 Mar 2026 04:55:46 GMT   test char::test_convert_const ... ok
Mon, 23 Mar 2026 04:55:47 GMT   test char::test_decode_utf16 ... ok
Mon, 23 Mar 2026 04:55:47 GMT   test char::test_decode_utf16_size_hint ... ok
Mon, 23 Mar 2026 04:55:47 GMT   test char::test_encode_utf16 ... ok
Mon, 23 Mar 2026 04:55:47 GMT   test char::test_encode_utf16_raw_buffer_too_small ... ok
Mon, 23 Mar 2026 04:55:47 GMT   test char::test_encode_utf8 ... ok
Mon, 23 Mar 2026 04:55:48 GMT   test char::test_encode_utf8_raw_buffer_too_small ... ok
Mon, 23 Mar 2026 04:55:49 GMT   test char::test_escape_debug ... ok
Mon, 23 Mar 2026 04:55:49 GMT   test char::test_escape_default ... ok

Causing hangs in the x86_64-gnu-aux job.

@rust-bors rust-bors bot removed the S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. label Mar 23, 2026
@rust-bors
Copy link
Contributor

rust-bors bot commented Mar 23, 2026

This PR was contained in a rollup (#154227), which was unapproved.

@Zalathar
Copy link
Member

Note that the x86_64-gnu-aux job runs stdlib tests under miri, making them much slower than when run normally.

Tests with many inputs/cases typically need to be excluded from miri testing, so that they don’t cause problems in that job.

@Jules-Bertholet
Copy link
Contributor Author

@rustbot ready

@rustbot rustbot added S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. and removed S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. labels Mar 23, 2026
@JonathanBrouwer
Copy link
Contributor

@bors try jobs=x86_64-gnu-aux

@rust-bors

This comment has been minimized.

rust-bors bot pushed a commit that referenced this pull request Mar 23, 2026
Add APIs for dealing with titlecase


try-job: x86_64-gnu-aux
@rust-bors
Copy link
Contributor

rust-bors bot commented Mar 23, 2026

☀️ Try build successful (CI)
Build commit: d8e76a8 (d8e76a8a24300a640229e839cc90c3cd6f868581, parent: bbe853615821442ef11d6cd42a30a73432b38d89)

@JonathanBrouwer
Copy link
Contributor

@bors r=Mark-Simulacrum

@rust-bors
Copy link
Contributor

rust-bors bot commented Mar 23, 2026

📌 Commit e1e903c has been approved by Mark-Simulacrum

It is now in the queue for this repository.

@rust-bors rust-bors bot added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Mar 23, 2026
JonathanBrouwer added a commit to JonathanBrouwer/rust that referenced this pull request Mar 23, 2026
…Simulacrum

Add APIs for dealing with titlecase

ACP: rust-lang/libs-team#354
Tracking issue: rust-lang#153892

r? libs-api

@rustbot label T-libs -T-libs-api A-unicode

~~The last commit has some insta-stable `PartialEq` impls, therefore: @rustbot label -needs-fcp
Alternatively, I could split those out into a follow-up PR.~~ (Edit: will do in follow-up)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

A-Unicode Area: Unicode S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. T-libs Relevant to the library team, which will review and decide on the PR/issue.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

9 participants