Make `missing_fragment_specifier` an unconditional error by tgross35 · Pull Request #128425 · rust-lang/rust

tgross35 · 2024-07-31T03:45:47Z

This was attempted in 1 then reverted in 2 because of fallout. Recently, this was made an edition-dependent error in 3.

Make missing fragment specifiers an unconditional error again, across all editions.

More context: #128006
Most recent crater: #128425 (comment)
Fixes: #40107

r? @petrochenkov

tgross35 · 2024-07-31T07:31:07Z

This is just to test the diagnostics, none of the possible code cleanup is included.

@petrochenkov please take a look when you get the chance and start crater if the change seems correct.

@bors try

…unconditional, r=<try> [crater] Make `missing_fragment_specifier` an unconditional error This was attempted in [1] then reverted in [2] because of fallout. Recently, this was made an edition-dependent error in [3]. Experiment with turning missing fragment specifiers an unconditional error again. More context: rust-lang#128006 [1]: rust-lang#75516 [2]: rust-lang#80210 [3]: rust-lang#128006

bors · 2024-07-31T07:32:19Z

⌛ Trying commit c2492ec with merge 063c08d...

bors · 2024-07-31T09:13:42Z

☀️ Try build successful - checks-actions
Build commit: 063c08d (063c08dd8db6ff113bb809c130456f1781abe72c)

petrochenkov · 2024-07-31T12:54:34Z

@craterbot check

craterbot · 2024-07-31T12:54:42Z

👌 Experiment pr-128425 created and queued.
🤖 Automatically detected try build 063c08d
🔍 You can check out the queue and this experiment's details.

ℹ️ Crater is a tool to run experiments across parts of the Rust ecosystem. Learn more

craterbot · 2024-08-09T12:35:40Z

🚧 Experiment pr-128425 is now running

ℹ️ Crater is a tool to run experiments across parts of the Rust ecosystem. Learn more

craterbot · 2024-08-11T15:07:21Z

🎉 Experiment pr-128425 is completed!
📊 156 regressed and 2 fixed (487733 total)
📰 Open the full report.

⚠️ If you notice any spurious failure please add them to the blacklist!
ℹ️ Crater is a tool to run experiments across parts of the Rust ecosystem. Learn more

tgross35 · 2024-08-14T06:03:30Z

rg 'missing fragment specifier' -l --stats in the logs reports 373 matches. The previous attempt in 2020 had 475 regressions per #76605, so that is slight improvement but not much.

Like the previous run, almost all of these (361) come from clap <= 2.20, based on a crude rg 'missing fragment specifier.*\n.*clap' -l --stats -U. Remaining 12:

build-fail/reg/sem/0.1.0/master#83dcdb3a5dad0ed1e3e1fadc848d3f7727b41aa5.txt-[INFO] [stdout]    --> src/macros.rs:121:17
build-fail/reg/sem/0.1.0/master#83dcdb3a5dad0ed1e3e1fadc848d3f7727b41aa5.txt-[INFO] [stdout]    --> src/macros.rs:136:17
build-fail/reg/sem/0.1.0/master#83dcdb3a5dad0ed1e3e1fadc848d3f7727b41aa5.txt-[INFO] [stdout]    --> src/macros.rs:121:17
build-fail/reg/sem/0.1.0/master#83dcdb3a5dad0ed1e3e1fadc848d3f7727b41aa5.txt-[INFO] [stdout]    --> src/macros.rs:136:17
build-fail/reg/sem/0.1.0/try#063c08dd8db6ff113bb809c130456f1781abe72c.txt-[INFO] [stdout]    --> src/macros.rs:121:17
build-fail/reg/sem/0.1.0/try#063c08dd8db6ff113bb809c130456f1781abe72c.txt-[INFO] [stdout]    --> src/macros.rs:136:17
build-fail/reg/sem/0.1.0/try#063c08dd8db6ff113bb809c130456f1781abe72c.txt-[INFO] [stdout]    --> src/macros.rs:121:17
build-fail/reg/sem/0.1.0/try#063c08dd8db6ff113bb809c130456f1781abe72c.txt-[INFO] [stdout]    --> src/macros.rs:136:17
build-fail/reg/sem/0.1.0/try#063c08dd8db6ff113bb809c130456f1781abe72c.txt-[INFO] [stdout]    --> src/macros.rs:121:17
build-fail/reg/sem/0.1.0/try#063c08dd8db6ff113bb809c130456f1781abe72c.txt-[INFO] [stdout]    --> src/macros.rs:121:17
build-fail/reg/sem/0.1.0/try#063c08dd8db6ff113bb809c130456f1781abe72c.txt-[INFO] [stdout]    --> src/macros.rs:136:17
build-fail/reg/sem/0.1.0/try#063c08dd8db6ff113bb809c130456f1781abe72c.txt-[INFO] [stdout]    --> src/macros.rs:136:17

We could let this simmer for a while with the new error in deps level (#128122) and/or the edition-dependent lint (#128006). I don't really know how to feel about these results because all of the relevant clap versions have been yanked for ~4 years, per clap-rs/clap#2076.

Requesting compiler feedback for how to proceed. Context: this was made an e2024 error in #128006, making it an error in all editions is being considered here.

@rustbot label +I-compiler-nominated

wesleywiser · 2024-08-15T14:58:09Z

Discussed briefly in the compiler team triage meeting. Given that nearly all regressions are on very old versions of clap and this has been a compatibility warning since 2017, we think it's reasonable to make this an unconditional error.

tgross35 · 2024-08-18T01:06:30Z

Thanks for discussing this. I'll wait for the next beta branch so #128122 is on stable for at least a cycle, then continue pushing this forward.

tgross35 · 2024-08-19T11:15:34Z

To reflect my above comment

@rustbot blocked

This lint is `allow`ed in a few places where it doesn't seem to be needed. The `missing_fragment_specifier` lint will be going away in a future version of Rust and replaced with a hard error [1], so update this now to avoid a future `unknown_lints` warning. [1]: rust-lang/rust#128425

tgross35 · 2025-06-10T00:34:32Z

Finally rebased this, I needed to do a few test updates.

@rustbot ready

petrochenkov · 2025-06-10T12:00:38Z

There's a list of removed lints in compiler\rustc_lint\src\lib.rs.
r=me after adding missing_fragment_specifier to that list (formally approved in #128425 (comment)).
@rustbot author

tgross35 · 2025-06-10T18:18:21Z

Added to the removed lint list https://github.com/rust-lang/rust/compare/59997821a886ca515ff17af950dbf4498f8975bf..1dc388b13663eb64cca8cbe76ee97c00985e3d91

@bors r=petrochenkov,traviscross

bors · 2025-06-10T18:18:24Z

📌 Commit 1dc388b has been approved by petrochenkov,traviscross

It is now in the queue for this repository.

bors · 2025-06-12T07:24:52Z

☔ The latest upstream changes (presumably #142392) made this pull request unmergeable. Please resolve the merge conflicts.

This was attempted in [1] then reverted in [2] because of fallout. Recently, this was made an edition-dependent error in [3]. Make missing fragment specifiers an unconditional error again. [1]: rust-lang#75516 [2]: rust-lang#80210 [3]: rust-lang#128006

tgross35 · 2025-06-12T07:57:42Z

Resolved conflicts.

@bors r=petrochenkov,traviscross

bors · 2025-06-12T07:57:44Z

📌 Commit 841f7ce has been approved by petrochenkov,traviscross

It is now in the queue for this repository.

Kobzol · 2025-06-17T06:28:55Z

@rust-timer build 21dbb46

(Testing #142443)

rust-timer · 2025-06-17T07:54:40Z

Finished benchmarking commit (21dbb46): comparison URL.

Overall result: ❌ regressions - no action needed

Benchmarking this pull request means it may be perf-sensitive – we'll automatically label it not fit for rolling up. You can override this, but we strongly advise not to, due to possible changes in compiler perf.

@bors rollup=never
@rustbot label: -S-waiting-on-perf -perf-regression

Instruction count

Our most reliable metric. Used to determine the overall result above. However, even this metric can be noisy.

	mean	range	count
Regressions ❌ (primary)	-	-	0
Regressions ❌ (secondary)	0.1%	[0.1%, 0.1%]	1
Improvements ✅ (primary)	-	-	0
Improvements ✅ (secondary)	-	-	0
All ❌✅ (primary)	-	-	0

Max RSS (memory usage)

Results (primary 1.8%, secondary 2.0%)

A less reliable metric. May be of interest, but not used to determine the overall result above.

	mean	range	count
Regressions ❌ (primary)	1.8%	[1.8%, 1.8%]	1
Regressions ❌ (secondary)	2.0%	[1.6%, 2.4%]	2
Improvements ✅ (primary)	-	-	0
Improvements ✅ (secondary)	-	-	0
All ❌✅ (primary)	1.8%	[1.8%, 1.8%]	1

Cycles

Results (secondary 1.8%)

A less reliable metric. May be of interest, but not used to determine the overall result above.

	mean	range	count
Regressions ❌ (primary)	-	-	0
Regressions ❌ (secondary)	5.4%	[5.4%, 5.4%]	1
Improvements ✅ (primary)	-	-	0
Improvements ✅ (secondary)	-1.8%	[-1.8%, -1.8%]	1
All ❌✅ (primary)	-	-	0

Binary size

Results (secondary -0.0%)

A less reliable metric. May be of interest, but not used to determine the overall result above.

	mean	range	count
Regressions ❌ (primary)	-	-	0
Regressions ❌ (secondary)	-	-	0
Improvements ✅ (primary)	-	-	0
Improvements ✅ (secondary)	-0.0%	[-0.0%, -0.0%]	1
All ❌✅ (primary)	-	-	0

Bootstrap: 755.964s -> 690.641s (-8.64%)
Artifact size: 372.26 MiB -> 372.25 MiB (-0.00%)

rustbot assigned petrochenkov Jul 31, 2024

rustbot added S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. T-compiler Relevant to the compiler team, which will review and decide on the PR/issue. labels Jul 31, 2024

This comment has been minimized.

Sign in to view

tgross35 force-pushed the missing-fragment-specifier-unconditional branch 2 times, most recently from 392a2c7 to c2492ec Compare July 31, 2024 06:14

craterbot added S-waiting-on-crater Status: Waiting on a crater run to be completed. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Jul 31, 2024

tgross35 mentioned this pull request Aug 4, 2024

Tracking issue for future-incompatibility lint missing_fragment_specifier #40107

Closed

craterbot added S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. and removed S-waiting-on-crater Status: Waiting on a crater run to be completed. labels Aug 11, 2024

tgross35 mentioned this pull request Aug 14, 2024

Make missing_fragment_specifier an error in edition 2024 #128006

Merged

rustbot added the I-compiler-nominated Nominated for discussion during a compiler team meeting. label Aug 14, 2024

tgross35 mentioned this pull request Aug 14, 2024

missing_fragment_specifier points at the wrong span if followed by another metavariable #129077

Closed

petrochenkov added S-waiting-on-team and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Aug 14, 2024

apiraino removed the I-compiler-nominated Nominated for discussion during a compiler team meeting. label Aug 15, 2024

rustbot added the S-blocked Status: Blocked on something else such as an RFC or other implementation work. label Aug 19, 2024

apiraino removed the to-announce Announce this issue on triage meeting label Jun 5, 2025

tgross35 force-pushed the missing-fragment-specifier-unconditional branch from 5f0c38d to ed21403 Compare June 9, 2025 23:44

rustbot added the T-rustdoc-frontend Relevant to the rustdoc-frontend team, which will review and decide on the web UI/UX output. label Jun 9, 2025

tgross35 mentioned this pull request Jun 9, 2025

Remove allow(missing_fragment_specifier) saveoursecrets/sdk#765

Merged

tgross35 force-pushed the missing-fragment-specifier-unconditional branch from ed21403 to 5999782 Compare June 10, 2025 00:08

rustbot added S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. and removed S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. labels Jun 10, 2025

rustbot added S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Jun 10, 2025

tgross35 force-pushed the missing-fragment-specifier-unconditional branch from 5999782 to 1dc388b Compare June 10, 2025 18:17

fmease mentioned this pull request Jun 10, 2025

Rollup of 13 pull requests #142313

Closed

This was referenced Jun 11, 2025

Rollup of 17 pull requests #142332

Closed

Rollup of 15 pull requests #142396

Closed

Rollup of 15 pull requests #142397

Closed

tgross35 added 2 commits June 12, 2025 07:35

Fix a missing fragment specifier in rustdoc tests

208cb5d

matthiaskrgr mentioned this pull request Jun 13, 2025

Rollup of 9 pull requests #142443

Merged

This comment has been minimized.

Sign in to view

tgross35 mentioned this pull request Jun 18, 2025

mbe: Clean up code with non-optional NonterminalKind #142657

Merged

cuviper mentioned this pull request Jul 17, 2025

Draft release notes for 1.89.0 #144097

Closed

Uh oh!

Conversation

tgross35 commented Jul 31, 2024 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

This comment has been minimized.

tgross35 commented Jul 31, 2024

Uh oh!

bors commented Jul 31, 2024

Uh oh!

bors commented Jul 31, 2024

Uh oh!

petrochenkov commented Jul 31, 2024

Uh oh!

craterbot commented Jul 31, 2024

Uh oh!

craterbot commented Aug 9, 2024

Uh oh!

craterbot commented Aug 11, 2024

Uh oh!

tgross35 commented Aug 14, 2024 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

wesleywiser commented Aug 15, 2024

Uh oh!

tgross35 commented Aug 18, 2024

Uh oh!

tgross35 commented Aug 19, 2024

Uh oh!

tgross35 commented Jun 10, 2025

Uh oh!

petrochenkov commented Jun 10, 2025

Uh oh!

tgross35 commented Jun 10, 2025

Uh oh!

bors commented Jun 10, 2025

Uh oh!

bors commented Jun 12, 2025

Uh oh!

tgross35 commented Jun 12, 2025

Uh oh!

bors commented Jun 12, 2025

Uh oh!

Kobzol commented Jun 17, 2025

Uh oh!

This comment has been minimized.

rust-timer commented Jun 17, 2025

Overall result: ❌ regressions - no action needed

Instruction count

Max RSS (memory usage)

Cycles

Binary size

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

16 participants

tgross35 commented Jul 31, 2024 •

edited

Loading

tgross35 commented Aug 14, 2024 •

edited

Loading