Adjust the alignment when passing a niche as a pointer#131739
Closed
dianqk wants to merge 1 commit intorust-lang:masterfrom
Closed
Adjust the alignment when passing a niche as a pointer#131739dianqk wants to merge 1 commit intorust-lang:masterfrom
dianqk wants to merge 1 commit intorust-lang:masterfrom
Conversation
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Context: Segfault at optlevel >= 1.
When passing a niche as a pointer, we have to consider drop
alignanddereferenceable. The issue aboutdereferenceableis #131834.Take https://rust.godbolt.org/z/rbxqKedG6 as an example: we pass
E::Bwith a value of32769as a parameter, and it's clear that the alignment of this as an address is not 8.Instead of dropping the
alignwe could probably also shorten it, but we don't have a clear example to show it makes sense for optimization.r? @the8472 or @saethlin