reject aarch64 target feature toggling that would change the float ABI#133417
Merged
bors merged 4 commits intorust-lang:masterfrom Dec 15, 2024
Merged
reject aarch64 target feature toggling that would change the float ABI#133417bors merged 4 commits intorust-lang:masterfrom
bors merged 4 commits intorust-lang:masterfrom
Conversation
Loading
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
6 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Stacked on top of #133099. Only the last two commits are new.The first new commit lays the groundwork for separately controlling whether a feature may be enabled or disabled. The second commit uses that to make it illegal to disable the
neonfeature (which is only possible via-Ctarget-feature, and so the new check just adds a warning). Enabling theneonfeature remains allowed on targets that don't disableneonorfp-armv8, which is all our built-in targets. This way, the entire PR is not a breaking change.Fixes #131058 for hardfloat targets (together with #133102 which fixed it for softfloat targets).
Part of #116344.