Try unremapping compiler sources#142377
Merged
bors merged 2 commits intorust-lang:masterfrom Jun 19, 2025
Merged
Conversation
Loading
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
See #t-compiler/help > Span pointing to wrong file location (
rustc-devcomponent).This PR is a follow-up to #141751 regarding the compiler side.
Specifically we now take into account the
CFG_VIRTUAL_RUSTC_DEV_SOURCE_BASE_DIRenv from #141751 when trying to unremap sources from$sysroot/lib/rustlib/rustc-src/rust(therustc-devcomponent install directory).Best reviewed commit by commit.
cc @samueltardieu
r? @jieyouxu