Mark method receivers in builtin derives as being from the derive.

[Jarcho]

View all comments

Another small annoyance while working on clippy. This was clearly using the root context on purpose, but it also has no reason to do so. All the uses of the receiver are generated by the macros so they can just use the marked context rather than the root.

[rustbot]

r? @jackh726

rustbot has assigned @jackh726.
They will have a look at your PR within the next two weeks and either review your PR or reassign to another reviewer.

Use r? to explicitly pick a reviewer

[jackh726]

Any test that we can add here?

[Jarcho]

Clippy will eventually end up with a test that covers this, but I don't think I can easily add anything here. At least I don't know of any way to test the context of arbitrary tokens.

For context this is from testing the code in Clippy which detects when a proc-macro generates tokens with a span which has the context of the macro's input, but weren't actually part of the input.

[jackh726]

I'm pretty unfamiliar with out we could add a test for this . Maybe @petrochenkov would know.

At the least, maybe you can provide some concrete example of what would change here.

Is the span meaningful here or is it e.g. only used for diagnostics?

[jackh726]

shrug This seems obviously simple and okay.

@bors r+

[rust-bors]

📌 Commit 076064f has been approved by jackh726

It is now in the queue for this repository.

[tgross35]

Maybe #154628 (comment)?

@bors try jobs=aarch64-gnu-llvm-21-1

[rust-bors]

💔 Test for a2ea554 failed: CI. Failed job:

• try - aarch64-gnu-llvm-21-1 (web logs, enhanced plaintext logs)

[tgross35]

@bors r-

[rust-bors]

This pull request was unapproved.

This PR was contained in a rollup (#154629), which was unapproved.

[rustbot]

Some changes occurred in src/tools/rustfmt

cc @rust-lang/rustfmt

[rustbot]

This PR was rebased onto a different main commit. Here's a range-diff highlighting what actually changed.

Rebasing is a normal part of keeping PRs up to date, so no action is needed—this note is just to help reviewers.

[Jarcho]

At the least, maybe you can provide some concrete example of what would change here.

Is the span meaningful here or is it e.g. only used for diagnostics?

Missed this earlier. This changes the context of the self receiver ident to be part of the macro expansion context instead of the root context for all builtin derives. e.g. for Clone this would be:

impl Clone for T {
  fn clone(
    &self // this `self`'s context.
  ) -> Self {
    Self {
      x: self.x.clone() // also this `self`'s context.
    }
  }
}

The context shouldn't change the meaning here since the receiver on any of the generated methods isn't accessible to anything outside the macro generated code in the first place.

From a linting perspective self appearing to be from a non-macro context can be annoying. This particular context problem only comes up while stress testing our detection of bad proc-macro spans. None of our lints will be tripped up by this since all the surrounding tokens have an appropriate context.

[ytmimi]

@rustbot label -T-rustfmt

[jackh726]

@bors r+

[rust-bors]

📌 Commit 5394268 has been approved by jackh726

It is now in the queue for this repository.

[rust-bors]

☀️ Test successful - CI
Approved by: jackh726
Duration: 3h 8m 26s
Pushing a92a99e to main...

[github-actions]

What is this?

This is an experimental post-merge analysis report that shows differences in test outcomes between the merged PR and its parent PR.

Comparing fff9e44 (parent) -> a92a99e (this PR)

Test differences

Show 2 test diffs

2 doctest diffs were found. These are ignored, as they are noisy.

Test dashboard

Run

cargo run --manifest-path src/ci/citool/Cargo.toml -- \
    test-dashboard a92a99ef1479a9987b0ef76a064c2bd8e779babd --output-dir test-dashboard

And then open test-dashboard/index.html in your browser to see an overview of all executed tests.

Job duration changes

1. pr-check-2: 35m 34s -> 41m 12s (+15.9%)
2. tidy: 2m 48s -> 2m 24s (-14.1%)
3. dist-apple-various: 1h 33m -> 1h 21m (-12.5%)
4. dist-powerpc-linux: 1h 35m -> 1h 23m (-12.3%)
5. x86_64-mingw-2: 2h 27m -> 2h 40m (+9.4%)
6. aarch64-apple: 2h 38m -> 2h 52m (+9.3%)
7. dist-x86_64-apple: 1h 55m -> 2h 5m (+8.9%)
8. dist-x86_64-musl: 2h 21m -> 2h 9m (-8.1%)
9. arm-android: 1h 41m -> 1h 33m (-8.1%)
10. x86_64-gnu-aux: 2h 5m -> 2h 15m (+7.7%)

How to interpret the job duration changes?

Job durations can vary a lot, based on the actual runner instance
that executed the job, system noise, invalidated caches, etc. The table above is provided
mostly for t-infra members, for simpler debugging of potential CI slow-downs.

[rust-timer]

Finished benchmarking commit (a92a99e): comparison URL.

Overall result: ❌ regressions - no action needed

@rustbot label: -perf-regression

Instruction count

Our most reliable metric. Used to determine the overall result above. However, even this metric can be noisy.

	mean	range	count
Regressions ❌ (primary)	-	-	0
Regressions ❌ (secondary)	0.2%	[0.2%, 0.2%]	1
Improvements ✅ (primary)	-	-	0
Improvements ✅ (secondary)	-	-	0
All ❌✅ (primary)	-	-	0

Max RSS (memory usage)

Results (primary -0.7%)

A less reliable metric. May be of interest, but not used to determine the overall result above.

	mean	range	count
Regressions ❌ (primary)	-	-	0
Regressions ❌ (secondary)	-	-	0
Improvements ✅ (primary)	-0.7%	[-0.7%, -0.7%]	2
Improvements ✅ (secondary)	-	-	0
All ❌✅ (primary)	-0.7%	[-0.7%, -0.7%]	2

Cycles

Results (secondary -3.6%)

A less reliable metric. May be of interest, but not used to determine the overall result above.

	mean	range	count
Regressions ❌ (primary)	-	-	0
Regressions ❌ (secondary)	-	-	0
Improvements ✅ (primary)	-	-	0
Improvements ✅ (secondary)	-3.6%	[-4.7%, -2.4%]	2
All ❌✅ (primary)	-	-	0

Binary size

Results (secondary -0.0%)

A less reliable metric. May be of interest, but not used to determine the overall result above.

	mean	range	count
Regressions ❌ (primary)	-	-	0
Regressions ❌ (secondary)	-	-	0
Improvements ✅ (primary)	-	-	0
Improvements ✅ (secondary)	-0.0%	[-0.1%, -0.0%]	8
All ❌✅ (primary)	-	-	0

Bootstrap: 488.874s -> 487.739s (-0.23%)
Artifact size: 395.28 MiB -> 395.17 MiB (-0.03%)