Link LLVM dynamically on aarch64-apple-darwin

[sgasho]

View all comments

Follow-up to #152768.

• Link LLVM dynamically on MacOS
• Fix a macOS LLVM dylib name mismatch

[ZuseZ4]

@bors delegate try

[rust-bors]

Unknown command "delegate". Run @bors help to see available commands.

[ZuseZ4]

Hmm, not sure about the exact syntax, but delegate itself should have been recognized, maybe not ported to the new bots yet? I'll let Jakub handle it.
For now

@bors try jobs=dist-aarch64-apple

[Kobzol]

@bors delegate=try

[rust-bors]

✌️ @sgasho, you can now perform try builds on this pull request!

You can now post @bors try to start a try build.

[rust-bors]

☀️ Try build successful (CI)
Build commit: a658070 (a65807068ca7fef2605b24756206b9e5dfa49bbd, parent: db1484bdee1cb065b322a5bd512b39c49dadc9e5)

[rust-bors]

☔ The latest upstream changes (presumably #150541) made this pull request unmergeable. Please resolve the merge conflicts.

[sgasho]

@bors try jobs=dist-aarch64-apple

[sgasho]

@bors try jobs=dist-aarch64-apple

[sgasho]

@bors try jobs=dist-aarch64-apple

[rust-bors]

💔 Test for 2c9be7e failed: CI. Failed job:

• try - dist-aarch64-apple (web logs, enhanced plaintext logs)

[rust-bors]

☀️ Try build successful (CI)
Build commit: e9082b0 (e9082b0b5e7003739ca4f66d9151b541644e4398, parent: 7218b7fa17e8ef5e99525ae25e6e82224c27039d)

[sgasho]

@bors try jobs=dist-aarch64-apple,aarch64-apple

[rust-bors]

☀️ Try build successful (CI)
Build commit: a04723f (a04723f3b8616cce57bf04d947a441ba2e27b38e, parent: 562dee4820c458d823175268e41601d4c060588a)

[sgasho]

Current commit is the final state after addressing the reviews.

• Added some comments on code changes
• Removed enzyme from the dist command as below
  • 

@RalfJung

Could you please run miri check again if you think you need to do it(maybe not)?

[RalfJung]

If nothing changed about the dist artifact, I don't think we have to re-test.

[rustbot]

r? @davidtwco

rustbot has assigned @davidtwco.
They will have a look at your PR within the next two weeks and either review your PR or reassign to another reviewer.

Use r? to explicitly pick a reviewer

Why was this reviewer chosen?

The reviewer was selected based on:

• Owners of files modified in this PR: @cuviper, compiler
• @cuviper, compiler expanded to 69 candidates
• Random selection from 13 candidates

[ZuseZ4]

The perf concern is addressed, and the name adjustment was confirmed to work by at least one downstream user. I don't see any outstanding concerns, so let's try again.

@bors r+ rollup=never

[rust-bors]

📌 Commit e7c268f has been approved by ZuseZ4

It is now in the queue for this repository.

[rust-bors]

☀️ Test successful - CI
Approved by: ZuseZ4
Duration: 3h 8m 38s
Pushing cde9cf0 to main...

[github-actions]

What is this?

This is an experimental post-merge analysis report that shows differences in test outcomes between the merged PR and its parent PR.

Comparing 9df8317 (parent) -> cde9cf0 (this PR)

Test differences

Show 2 test diffs

2 doctest diffs were found. These are ignored, as they are noisy.

Test dashboard

Run

cargo run --manifest-path src/ci/citool/Cargo.toml -- \
    test-dashboard cde9cf08d7a79042758db8d5d824d0341da97f7a --output-dir test-dashboard

And then open test-dashboard/index.html in your browser to see an overview of all executed tests.

Job duration changes

1. x86_64-rust-for-linux: 52m 46s -> 43m 54s (-16.8%)
2. x86_64-gnu-llvm-22-2: 1h 40m -> 1h 24m (-15.9%)
3. armhf-gnu: 1h 36m -> 1h 22m (-14.8%)
4. optional-x86_64-gnu-parallel-frontend: 2h 30m -> 2h 8m (-14.6%)
5. pr-check-1: 32m 56s -> 28m 9s (-14.5%)
6. x86_64-gnu-debug: 2h 3m -> 1h 48m (-12.7%)
7. x86_64-gnu-llvm-21-1: 1h 17m -> 1h 9m (-9.9%)
8. i686-gnu-2: 1h 41m -> 1h 31m (-9.6%)
9. x86_64-msvc-ext3: 1h 53m -> 1h 42m (-9.4%)
10. aarch64-gnu: 2h 17m -> 2h 4m (-9.1%)

How to interpret the job duration changes?

Job durations can vary a lot, based on the actual runner instance
that executed the job, system noise, invalidated caches, etc. The table above is provided
mostly for t-infra members, for simpler debugging of potential CI slow-downs.

[rust-timer]

Finished benchmarking commit (cde9cf0): comparison URL.

Overall result: no relevant changes - no action needed

@rustbot label: -perf-regression

Instruction count

This benchmark run did not return any relevant results for this metric.

Max RSS (memory usage)

Results (primary -0.2%, secondary -2.2%)

A less reliable metric. May be of interest, but not used to determine the overall result above.

	mean	range	count
Regressions ❌ (primary)	2.5%	[1.6%, 2.9%]	4
Regressions ❌ (secondary)	0.8%	[0.8%, 0.8%]	1
Improvements ✅ (primary)	-2.9%	[-3.4%, -2.0%]	4
Improvements ✅ (secondary)	-3.2%	[-3.5%, -3.0%]	3
All ❌✅ (primary)	-0.2%	[-3.4%, 2.9%]	8

Cycles

Results (primary 2.3%, secondary 2.4%)

A less reliable metric. May be of interest, but not used to determine the overall result above.

	mean	range	count
Regressions ❌ (primary)	2.3%	[2.1%, 2.5%]	3
Regressions ❌ (secondary)	2.4%	[2.4%, 2.4%]	1
Improvements ✅ (primary)	-	-	0
Improvements ✅ (secondary)	-	-	0
All ❌✅ (primary)	2.3%	[2.1%, 2.5%]	3

Binary size

This benchmark run did not return any relevant results for this metric.

Bootstrap: 486.263s -> 486.46s (0.04%)
Artifact size: 394.97 MiB -> 394.96 MiB (-0.00%)