Skip to content

Revert "Rollup merge of #154200 - resrever:enable-dwarf-call-sites, r=dingxiangfei2009"#154468

Open
Kobzol wants to merge 1 commit intorust-lang:mainfrom
Kobzol:revert-154200
Open

Revert "Rollup merge of #154200 - resrever:enable-dwarf-call-sites, r=dingxiangfei2009"#154468
Kobzol wants to merge 1 commit intorust-lang:mainfrom
Kobzol:revert-154200

Conversation

@Kobzol
Copy link
Copy Markdown
Member

@Kobzol Kobzol commented Mar 27, 2026

This reverts commit 2f16030, reversing
changes made to 6e3c174.

Debugging perf. hit from #154384.

The binary size hits from #154468 (comment) were due to this PR, not all of the copmile-time hits though.

@rustbot rustbot added A-LLVM Area: Code generation parts specific to LLVM. Both correctness bugs and optimization-related issues. S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. T-compiler Relevant to the compiler team, which will review and decide on the PR/issue. labels Mar 27, 2026
@Kobzol
Copy link
Copy Markdown
Member Author

Kobzol commented Mar 27, 2026

@bors try @rust-timer queue

@rust-timer

This comment has been minimized.

@rust-bors

This comment has been minimized.

rust-bors bot pushed a commit that referenced this pull request Mar 27, 2026
Revert "Rollup merge of #154200 - resrever:enable-dwarf-call-sites, r=dingxiangfei2009"
@rustbot rustbot added the S-waiting-on-perf Status: Waiting on a perf run to be completed. label Mar 27, 2026
@rust-log-analyzer

This comment has been minimized.

@rust-bors
Copy link
Copy Markdown
Contributor

rust-bors bot commented Mar 27, 2026

☀️ Try build successful (CI)
Build commit: 1be14f9 (1be14f9c29eac4f8fbbc914df19f7a287c41ed9d, parent: fda6d37bb88ee12fd50fa54d15859f1f91b74f55)

@rust-timer

This comment has been minimized.

@rust-timer
Copy link
Copy Markdown
Collaborator

Finished benchmarking commit (1be14f9): comparison URL.

Overall result: ✅ improvements - no action needed

Benchmarking this pull request means it may be perf-sensitive – we'll automatically label it not fit for rolling up. You can override this, but we strongly advise not to, due to possible changes in compiler perf.

@bors rollup=never
@rustbot label: -S-waiting-on-perf -perf-regression

Instruction count

Our most reliable metric. Used to determine the overall result above. However, even this metric can be noisy.

mean range count
Regressions ❌
(primary)
- - 0
Regressions ❌
(secondary)
- - 0
Improvements ✅
(primary)
-0.5% [-1.0%, -0.2%] 18
Improvements ✅
(secondary)
-0.6% [-0.9%, -0.3%] 20
All ❌✅ (primary) -0.5% [-1.0%, -0.2%] 18

Max RSS (memory usage)

Results (primary -0.7%, secondary 2.3%)

A less reliable metric. May be of interest, but not used to determine the overall result above.

mean range count
Regressions ❌
(primary)
3.2% [3.2%, 3.2%] 1
Regressions ❌
(secondary)
5.8% [4.4%, 7.2%] 2
Improvements ✅
(primary)
-2.0% [-2.2%, -1.8%] 3
Improvements ✅
(secondary)
-4.6% [-4.6%, -4.6%] 1
All ❌✅ (primary) -0.7% [-2.2%, 3.2%] 4

Cycles

Results (primary 2.5%, secondary -3.7%)

A less reliable metric. May be of interest, but not used to determine the overall result above.

mean range count
Regressions ❌
(primary)
2.5% [2.5%, 2.5%] 1
Regressions ❌
(secondary)
- - 0
Improvements ✅
(primary)
- - 0
Improvements ✅
(secondary)
-3.7% [-5.0%, -2.5%] 2
All ❌✅ (primary) 2.5% [2.5%, 2.5%] 1

Binary size

Results (primary -1.7%, secondary -1.7%)

A less reliable metric. May be of interest, but not used to determine the overall result above.

mean range count
Regressions ❌
(primary)
- - 0
Regressions ❌
(secondary)
- - 0
Improvements ✅
(primary)
-1.7% [-3.5%, -0.0%] 72
Improvements ✅
(secondary)
-1.7% [-4.4%, -0.0%] 71
All ❌✅ (primary) -1.7% [-3.5%, -0.0%] 72

Bootstrap: 485.109s -> 494.056s (1.84%)
Artifact size: 395.05 MiB -> 394.95 MiB (-0.02%)

@rustbot rustbot removed the S-waiting-on-perf Status: Waiting on a perf run to be completed. label Mar 27, 2026
@Kobzol Kobzol marked this pull request as ready for review March 27, 2026 19:07
@rustbot rustbot added the S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. label Mar 27, 2026
@rustbot rustbot removed the S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. label Mar 27, 2026
@rustbot
Copy link
Copy Markdown
Collaborator

rustbot commented Mar 27, 2026

r? @dingxiangfei2009

rustbot has assigned @dingxiangfei2009.
They will have a look at your PR within the next two weeks and either review your PR or reassign to another reviewer.

Use r? to explicitly pick a reviewer

Why was this reviewer chosen?

The reviewer was selected based on:

  • Owners of files modified in this PR: compiler, debuginfo
  • compiler, debuginfo expanded to 69 candidates
  • Random selection from 12 candidates

@rustbot

This comment has been minimized.

…-sites, r=dingxiangfei2009"

This reverts commit 2f16030, reversing
changes made to 6e3c174.
@rustbot
Copy link
Copy Markdown
Collaborator

rustbot commented Mar 27, 2026

⚠️ Warning ⚠️

  • There are issue links (such as #123) in the commit messages of the following commits.
    Please move them to the PR description, to avoid spamming the issues with references to the commit, and so this bot can automatically canonicalize them to avoid issues with subtree.

@dingxiangfei2009
Copy link
Copy Markdown
Contributor

@bors r+ rollup=always

@rust-bors
Copy link
Copy Markdown
Contributor

rust-bors bot commented Mar 27, 2026

📌 Commit 8b44562 has been approved by dingxiangfei2009

It is now in the queue for this repository.

@rust-bors rust-bors bot added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Mar 27, 2026
@dingxiangfei2009
Copy link
Copy Markdown
Contributor

This looks like a binary size improvement that is large enough.

@JonathanBrouwer
Copy link
Copy Markdown
Contributor

This has perf effect, so @bors rollup=never

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

A-LLVM Area: Code generation parts specific to LLVM. Both correctness bugs and optimization-related issues. S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. T-compiler Relevant to the compiler team, which will review and decide on the PR/issue.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

6 participants