Skip to content

Conversation

@Jamesbarford
Copy link
Contributor

@Jamesbarford Jamesbarford commented Dec 11, 2025

Creates targets=<...> functionality, defaulting to x86_64-unknown-linux-gnu in the database.

Copy link
Member

@Kobzol Kobzol left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks! Could you please also update https://perf.rust-lang.org/help.html?

I realized now that we should also check for duplicates (in profiles/backends/targets), because submitting the same parameter twice will probably result in an error from the DB, or at least it will be unexpected and should be an early error after a command is posted. But that's for a separate PR.

@Kobzol
Copy link
Member

Kobzol commented Dec 12, 2025

Could you please also change the default value of targets to be an empty string, as per the comment above? Thanks!

Copy link
Member

@Kobzol Kobzol left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks! Let's try it.

@Kobzol Kobzol added this pull request to the merge queue Dec 12, 2025
Merged via the queue into rust-lang:master with commit c4075bf Dec 12, 2025
14 checks passed
@Jamesbarford Jamesbarford deleted the feat/allow-target-selection branch December 12, 2025 12:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants