Skip to content

Add Stable status to merge_imports configuration docs (#6643)#6828

Merged
ytmimi merged 3 commits intorust-lang:mainfrom
zichen0116:docs/add-stable-status-to-merge-imports
Mar 15, 2026
Merged

Add Stable status to merge_imports configuration docs (#6643)#6828
ytmimi merged 3 commits intorust-lang:mainfrom
zichen0116:docs/add-stable-status-to-merge-imports

Conversation

@zichen0116
Copy link
Contributor

@zichen0116 zichen0116 commented Mar 12, 2026

  • Add '- Stable: No' line to merge_imports section
  • Remove extra blank line before newline_style section
  • Follow same format as other deprecated options like reorder_imports

Closes #6643

@rustbot rustbot added the S-waiting-on-review Status: awaiting review from the assignee but also interested parties. label Mar 12, 2026
Copy link
Contributor

@ytmimi ytmimi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Also link to the tracking issues and remove unnecessary whitespace changes.

View changes since this review

use foo::{a, b, c, d, e, f, g};
```


Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

revert


- **Default value**: `false`
- **Possible values**: `true`, `false`
- **Stable**: No
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
- **Stable**: No
- **Stable**: No (tracking issue: [#3362](https://github.com/rust-lang/rustfmt/issues/3362))

@rustbot rustbot added S-waiting-on-author Status: awaiting some action (such as code changes or more information) from the author. and removed S-waiting-on-review Status: awaiting review from the assignee but also interested parties. labels Mar 12, 2026
@rustbot
Copy link
Collaborator

rustbot commented Mar 12, 2026

Reminder, once the PR becomes ready for a review, use @rustbot ready.

@zichen0116
Copy link
Contributor Author

@rustbot ready

@rustbot rustbot added S-waiting-on-review Status: awaiting review from the assignee but also interested parties. and removed S-waiting-on-author Status: awaiting some action (such as code changes or more information) from the author. labels Mar 13, 2026
Copy link
Contributor

@ytmimi ytmimi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@zichen0116 please revert the whitespace changes you made.

View changes since this review

@rustbot rustbot added S-waiting-on-author Status: awaiting some action (such as code changes or more information) from the author. and removed S-waiting-on-review Status: awaiting review from the assignee but also interested parties. labels Mar 13, 2026
@zichen0116
Copy link
Contributor Author

@ytmimi I'm really sorry. I thought it was the extra blank lines I added. Thanks for your tolerance. Everything should be fine now

@zichen0116
Copy link
Contributor Author

@rustbot ready

@rustbot rustbot added S-waiting-on-review Status: awaiting review from the assignee but also interested parties. and removed S-waiting-on-author Status: awaiting some action (such as code changes or more information) from the author. labels Mar 14, 2026
- Add '- **Stable**: No' line to merge_imports section
- Remove extra blank line before newline_style section
- Follow same format as other deprecated options like reorder_imports
@ytmimi ytmimi force-pushed the docs/add-stable-status-to-merge-imports branch from c55fd94 to 6b73246 Compare March 15, 2026 15:57
@rustbot
Copy link
Collaborator

rustbot commented Mar 15, 2026

This PR was rebased onto a different main commit. Here's a range-diff highlighting what actually changed.

Rebasing is a normal part of keeping PRs up to date, so no action is needed—this note is just to help reviewers.

@ytmimi ytmimi merged commit e6d1d52 into rust-lang:main Mar 15, 2026
26 checks passed
@rustbot rustbot added release-notes Needs an associated changelog entry and removed S-waiting-on-review Status: awaiting review from the assignee but also interested parties. labels Mar 15, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

release-notes Needs an associated changelog entry

Projects

None yet

Development

Successfully merging this pull request may close these issues.

merge_imports documentation missing "Stable" info

3 participants