fix(features): enable x509-parser/verify-aws if aws_lc_rs is selected #385
+19
−11
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Otherwise we pull in `ring` and `aws-lc-rs`. This is broken until a new release of x509-parser with this fix: rusticata/x509-parser@b7dcc93 Signed-off-by: Jalil David Salamé Messina <[email protected]> Change-Id: I6a6a69645257dc0e894279ced2408ec9df61a9d6
jalil-salame
force-pushed
the
push-uxusmnzlrqvx
branch
from
6bbefe3 to
28eacb1
Compare
Author
|
CI passes, this is wrong, CI doesn't test building with the |
Member
|
I suspect this fell off everyone's radar. Let's continue with #398 which builds clean. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Otherwise we pull in
ringandaws-lc-rs.This is broken until a new release of x509-parser with this fix: rusticata/x509-parser@b7dcc93