Epic/sapio study integration#5898
Open
wendyyang wants to merge 94 commits into
Open
Conversation
…apio_study_integration
wendyyang
marked this pull request as ready for review
July 24, 2026 13:11
StephenHulme
approved these changes
Jul 24, 2026
StephenHulme
left a comment
StephenHulme
left a comment
Member
There was a problem hiding this comment.
Good work on a challenging integration
Comment on lines
+60
to
+68
| render status: :forbidden, | ||
| json: { | ||
| errors: [ | ||
| { | ||
| title: 'Forbidden', | ||
| detail: 'Integration Hub API key required.' | ||
| } | ||
| ] | ||
| } |
Member
There was a problem hiding this comment.
praise: nice handling of authentication failure
Comment on lines
+164
to
165
| # Checks whether the required JSON:API search filter parameter is absent or blank. | ||
| # Checks whether the required JSON:API search filter parameter is present? |
| example.run | ||
| Flipper.enable(:y26_172_enable_sapio_mastered_study_restrictions, sapio_restrictions_enabled) | ||
| end | ||
|
|
Member
There was a problem hiding this comment.
Nice helper - makes testing much easier.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #
Changes proposed in this pull request
include the changes from y26-172 & y26-173
add a new field in Study table indicate mastered_in_sapio
block editing from SS UI
add condition in study controller
add update control in study model, only integration hub or console can update sapio study
add create API endpoint
feature flag with Flipper.
Instructions for Reviewers
[All PRs] - Confirm PR template filled
[Feature Branches] - Review code
[Production Merges to
main]- Check story numbers included
- Check for debug code
- Check version