feat: adds Iso-Seq_cDNA_amp_primer tag group and tags#5923
Conversation
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## develop #5923 +/- ##
===========================================
- Coverage 84.85% 84.85% -0.01%
===========================================
Files 1492 1492
Lines 33936 33936
Branches 3613 3613
===========================================
- Hits 28797 28796 -1
- Misses 4293 4295 +2
+ Partials 846 845 -1
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
andrewsparkes
left a comment
andrewsparkes
left a comment
There was a problem hiding this comment.
Looks fine. Left a comment.
Have you checked nothing needs changing in the sample manifests for the tag columns and their validations? They might have a limit for the excel sheets for when they upload already tagged samples.
| # the warehouse has a constaint of 30 characters for oligos for some flowcell tables | ||
| # so we don't want to allow tags longer than that to be created as they will | ||
| # dead letter on entrance to the warehouse. | ||
| # That being said we are starting to get valid tags longer than 30 characters |
There was a problem hiding this comment.
I think the problem here is we are conflating multiple things that LIMS is not tracking properly. Oligo Tags for sequencing indexing are not the same thing as primers to aid with amplification (which are longer to ensure uniqueness and good attachment), but we are tracking them in the same field in LIMS. Hopefully this gets tackled better in the new LIMS.
There was a problem hiding this comment.
Ah interesting, I wasn't aware of that. Ill update the comment to include something along those lines.
These tags will only be used in new compound sample manifests being created specifically for this kinnex process. That being said the manifests do currently limit to 30 characters, wondering if that should be 60 to reflect the updated model or if its something that should be removed entirely. |
2 participants
Closes #5755
Changes proposed in this pull request
Additional context
Currently trying to identify if increasing the oligo length is acceptable. I know this has knock on affects downstream as the warehouse limits to 30 characters too.
We can't limit it at the DB level as prod has tags with oligos of length 99
I think bumping this to 60 is a reasonable middle ground. It should stop big copy-paste error tags and still allows these real tags. Another possibility is validating only on magic tag group tags, these are user inputted ones.