Skip to content

Y26-195 - Remove redundant UG200 batch descriptors - #5930

Merged
BenTopping merged 5 commits into
developfrom
Y26-195-modify-ug200-descriptors
Jul 24, 2026
Merged

Y26-195 - Remove redundant UG200 batch descriptors#5930
BenTopping merged 5 commits into
developfrom
Y26-195-modify-ug200-descriptors

Conversation

@BenTopping

@BenTopping BenTopping commented Jul 17, 2026

Copy link
Copy Markdown
Contributor

Closes #5857

Changes proposed in this pull request

  • Remove redundant UG200 descriptors

TODO

  • Move script to single_use directory instead of migration.✅
  • Confirm what to do with existing production data ✅
    • It doesn't look like UG200 is used yet at time of writing so no existing descriptors in lab events.
  • Confirm useq_wafer messaging still works with missing descriptors. ✅
    • Tested both with existing descriptors and without.

@BenTopping BenTopping changed the title wip: adds basic data mgiration for removing existing UG200 redundant … Y26-195 - Remove redundant UG200 batch descriptors Jul 17, 2026
@codecov

codecov Bot commented Jul 17, 2026

Copy link
Copy Markdown

Codecov Report

❌ Patch coverage is 30.00000% with 7 lines in your changes missing coverage. Please review.
✅ Project coverage is 84.83%. Comparing base (9387bea) to head (d5d416b).

Files with missing lines Patch % Lines
...se/2026_07_remove_ug200_redundant_descriptors.rake 30.00% 7 Missing ⚠️
Additional details and impacted files
@@             Coverage Diff             @@
##           develop    #5930      +/-   ##
===========================================
- Coverage    84.86%   84.83%   -0.04%     
===========================================
  Files         1495     1496       +1     
  Lines        33982    33992      +10     
  Branches      3621     3622       +1     
===========================================
- Hits         28840    28836       -4     
- Misses        4289     4308      +19     
+ Partials       853      848       -5     
Flag Coverage Δ
javascript 76.31% <ø> (ø)
ruby 84.69% <30.00%> (-0.07%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Harness.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@BenTopping
BenTopping force-pushed the Y26-195-modify-ug200-descriptors branch from 84b4450 to 6638718 Compare July 23, 2026 13:51
@BenTopping
BenTopping requested review from sabrine33 and yoldas July 23, 2026 14:18
@BenTopping
BenTopping marked this pull request as ready for review July 23, 2026 14:19

@yoldas yoldas left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think we need to remove the record loader entries as well.

ls -1 config/default_records/{descriptors,tasks}/*ultima_ug200*
config/default_records/descriptors/005_ultima_ug200_descriptors.yml
config/default_records/tasks/005_ultima_ug200_tasks.yml

@BenTopping

Copy link
Copy Markdown
Contributor Author

I think we need to remove the record loader entries as well.

ls -1 config/default_records/{descriptors,tasks}/*ultima_ug200*
config/default_records/descriptors/005_ultima_ug200_descriptors.yml
config/default_records/tasks/005_ultima_ug200_tasks.yml

Yes you are right. I had forgotten to commit the changes as was toggling them on/off while testing the rake task 🤦‍♂️
Added in d5d416b

@BenTopping
BenTopping requested a review from yoldas July 24, 2026 08:53

@yoldas yoldas left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good.

  • LabEvents part may be necessary for UAT cleanup.
  • Thanks for applying the single_use pattern for rake tasks here as well.

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is great! thank you for applying the single use pattern.
The changes looks okay to me, just one question, did you check if any data is been registered against the to-be-deleted descriptor in prod?

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yep good question, there are currently no UG200 batches at the time of writing.
If there were, it shouldn't be affected by the removal of these descriptor records as they are not directly linked. LabEvents (where descriptors are stored) create and store the values as hash with the name of the descriptor as the key and the field value as the value, they don't foreign key link to the records - (https://github.com/sanger/sequencescape/blob/develop/lib/acts_as_descriptable.rb#L37)

@BenTopping
BenTopping merged commit 3c6f990 into develop Jul 24, 2026
16 of 17 checks passed
@BenTopping
BenTopping deleted the Y26-195-modify-ug200-descriptors branch July 24, 2026 13:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Y26-195 - Modify UG200 sequencing pipeline fields

3 participants