Y26-195 - Remove redundant UG200 batch descriptors - #5930
Conversation
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## develop #5930 +/- ##
===========================================
- Coverage 84.86% 84.83% -0.04%
===========================================
Files 1495 1496 +1
Lines 33982 33992 +10
Branches 3621 3622 +1
===========================================
- Hits 28840 28836 -4
- Misses 4289 4308 +19
+ Partials 853 848 -5
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
84b4450 to
6638718
Compare
yoldas
left a comment
There was a problem hiding this comment.
I think we need to remove the record loader entries as well.
ls -1 config/default_records/{descriptors,tasks}/*ultima_ug200*
config/default_records/descriptors/005_ultima_ug200_descriptors.yml
config/default_records/tasks/005_ultima_ug200_tasks.yml
Yes you are right. I had forgotten to commit the changes as was toggling them on/off while testing the rake task 🤦♂️ |
yoldas
left a comment
There was a problem hiding this comment.
Looks good.
- LabEvents part may be necessary for UAT cleanup.
- Thanks for applying the single_use pattern for rake tasks here as well.
There was a problem hiding this comment.
This is great! thank you for applying the single use pattern.
The changes looks okay to me, just one question, did you check if any data is been registered against the to-be-deleted descriptor in prod?
There was a problem hiding this comment.
Yep good question, there are currently no UG200 batches at the time of writing.
If there were, it shouldn't be affected by the removal of these descriptor records as they are not directly linked. LabEvents (where descriptors are stored) create and store the values as hash with the name of the descriptor as the key and the field value as the value, they don't foreign key link to the records - (https://github.com/sanger/sequencescape/blob/develop/lib/acts_as_descriptable.rb#L37)
Closes #5857
Changes proposed in this pull request
TODO