SR-70364 - Manually accession samples from list#5937
Conversation
|
Adding a link to the sample name displayed in "View accession numbers for samples" would allow user to visit the sample page easily. This would be useful in the instances where no accession numbers were generated (as seen in the test data). |
|
Thanks for the suggestion @neilsycamore, I've added the link as can be seen in the updated screenshots. |
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## develop #5937 +/- ##
===========================================
- Coverage 84.86% 84.86% -0.01%
===========================================
Files 1495 1495
Lines 33982 34049 +67
Branches 3621 3624 +3
===========================================
+ Hits 28840 28896 +56
- Misses 4289 4306 +17
+ Partials 853 847 -6
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
andrewsparkes
left a comment
There was a problem hiding this comment.
General thoughts:
This is great and will save Neils time. Be sure to communicate it exists to SSRs at deployment.
I would limit the number of rows they can have so they don't try and put a list of 3,245 samples. If you haven't already. Make it clear what the limit is in the GUI. 20? 50?
Is there a case for a 3rd function that removes accession numbers from samples? We've had that in FS tickets. (can be another story/PR)
Code looks good otherwise
Closes SR-70364 and future similar tickets
Changes proposed in this pull request
Extends Admin > Accessioning tools:
Screenshots:
Instructions for Reviewers
[All PRs] - Confirm PR template filled
[Feature Branches] - Review code
[Production Merges to
main]- Check story numbers included
- Check for debug code
- Check version