Skip to content

SR-70364 - Manually accession samples from list#5937

Open
StephenHulme wants to merge 21 commits into
developfrom
sr-70364-accession-samples-in-list
Open

SR-70364 - Manually accession samples from list#5937
StephenHulme wants to merge 21 commits into
developfrom
sr-70364-accession-samples-in-list

Conversation

@StephenHulme

@StephenHulme StephenHulme commented Jul 21, 2026

Copy link
Copy Markdown
Member

Closes SR-70364 and future similar tickets

Changes proposed in this pull request

Extends Admin > Accessioning tools:

  • Allows a give list of samples to be accessioned by name
  • Verify the accession numbers from a list of sample names

Screenshots:

Screenshot 2026-07-22 at 09 43 29 Screenshot 2026-07-22 at 11 11 23

Instructions for Reviewers

[All PRs] - Confirm PR template filled
[Feature Branches] - Review code
[Production Merges to main]
    - Check story numbers included
    - Check for debug code
    - Check version

@StephenHulme StephenHulme self-assigned this Jul 21, 2026
@neilsycamore

Copy link
Copy Markdown
Contributor

Adding a link to the sample name displayed in "View accession numbers for samples" would allow user to visit the sample page easily. This would be useful in the instances where no accession numbers were generated (as seen in the test data).

@StephenHulme

Copy link
Copy Markdown
Member Author

Thanks for the suggestion @neilsycamore, I've added the link as can be seen in the updated screenshots.

@codecov

codecov Bot commented Jul 22, 2026

Copy link
Copy Markdown

Codecov Report

❌ Patch coverage is 97.33333% with 2 lines in your changes missing coverage. Please review.
✅ Project coverage is 84.86%. Comparing base (9387bea) to head (76b031c).

Files with missing lines Patch % Lines
...controllers/admin/accessioning_tools_controller.rb 97.72% 0 Missing and 1 partial ⚠️
app/frontend/entrypoints/accessioning_tools.js 96.66% 1 Missing ⚠️
Additional details and impacted files
@@             Coverage Diff             @@
##           develop    #5937      +/-   ##
===========================================
- Coverage    84.86%   84.86%   -0.01%     
===========================================
  Files         1495     1495              
  Lines        33982    34049      +67     
  Branches      3621     3624       +3     
===========================================
+ Hits         28840    28896      +56     
- Misses        4289     4306      +17     
+ Partials       853      847       -6     
Flag Coverage Δ
javascript 85.29% <96.66%> (+8.97%) ⬆️
ruby 84.72% <97.77%> (-0.03%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Harness.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@andrewsparkes andrewsparkes left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

General thoughts:
This is great and will save Neils time. Be sure to communicate it exists to SSRs at deployment.
I would limit the number of rows they can have so they don't try and put a list of 3,245 samples. If you haven't already. Make it clear what the limit is in the GUI. 20? 50?
Is there a case for a 3rd function that removes accession numbers from samples? We've had that in FS tickets. (can be another story/PR)
Code looks good otherwise

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants