cli: support local review of root commits - #372
Draft
OllieinCanada wants to merge 1 commit into
Draft
Conversation
Signed-off-by: OllieinCanada <73385593+OllieinCanada@users.noreply.github.com>
Collaborator
|
Hello,
would you mind elaborating on this? I am having a bit of trouble understanding the perceived usecase here |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #203
Summary
Allow
sashiko-cli localto review a repository's root commit.Root commits are checked out and reviewed directly because they have no parent
baseline. Ordinary commits continue through the existing parent-based patch
application path.
Root cause
The local CLI always constructed
<first commit>^when no baseline was given.That revision is invalid when the requested commit is the repository's first
commit, so the review subprocess exited before producing a result.
Changes
root..rootseries rangeValidation
cargo fmt --all -- --checkcargo clippy --all-targets --all-features --release -- -D warningsexcluded
No external Git server, AI provider, or paid API is required by the regression
tests.