reviewer: bypass embargo for clean patchsets - #375
Open
kuba-moo wants to merge 1 commit into
Open
Conversation
Embargoes currently delay every completed review until the configured deadline, including reviews which found no issues. The goal of embargo was to avoid people using Sashiko as public CI, submitting poorly tested code to get a review. The embargo is supposed to incentivize running reviews locally. If Sashiko has no review comments, however, we have nothing to hide. The submitter will not send another version based on Sashiko's result. OTOH knowing that the review is clean is useful to maintainers. Let's reveal the clean status immediately. Determine the outcome after the entire patchset has completed. Completed patchsets qualify for immediate release only when all applicable reviews are complete and none contains findings. Both new and pre-existing findings retain the original embargo. Failed, incomplete, and --no-ai reviews cannot qualify as clean. Keep the complete-clean criteria in the release query so incomplete patchsets cannot consume the polling batch. Claim each embargo atomically before queuing notifications. Allow stale claims to expire after a crash. Treat finding persistence errors as review failures so returned issues cannot be mistaken for a clean review. Share notification handling between immediate and deadline-based publication. Make notification insertion idempotent and keep clean patchsets eligible for polling retries. This prevents a partial release from stranding an embargo or duplicating output. Update the embargo documentation and add coverage for clean early release, pre-existing findings, incomplete reviews, and --no-ai handling. Signed-off-by: Jakub Kicinski <kuba@kernel.org>
kuba-moo
force-pushed
the
pr-embargo-updates
branch
from
July 25, 2026 22:52
1df6919 to
c3b86a0
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Adjust the embargo behavior to only hold back the review if we found issues. As explained in the commit message embargo is supposed to delay the next submission, if there is no feedback we can't cause re-submission.