Skip to content

feature: Added ability to create requirements.txt in create_requirements_json function #222

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
sababak merged 10 commits into from
Oct 27, 2025
Merged

feature: Added ability to create requirements.txt in create_requirements_json function #222

Changes from 1 commit
Commits
Show all changes
10 commits
Select commit Hold shift + click to select a range
48eaf3b
Adding inital implementation for creating a requirements.txt in write…
sababak Oct 15, 2025
b297a14
Formatted changes to write_json_files.py
sababak Oct 16, 2025
20dd957
Updated doc string for create_requirements_json to include added requ…
sababak Oct 16, 2025
d3c9502
DCO Remediation Commit for Samuel Babak <[email protected]>
sababak Oct 17, 2025
c900feb
Updated mapping of import/install names
sababak Oct 17, 2025
e56e093
Updated mapping of import/install names
sababak Oct 17, 2025
55251eb
formatted files
sababak Oct 17, 2025
e823d3e
added short tests for requirements.txt
sababak Oct 17, 2025
e72465e
updated documentation to include information about creating requireme…
sababak Oct 22, 2025
973fa82
DCO Remediation Commit for Samuel Babak <[email protected]>
sababak Oct 22, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
54 changes: 28 additions & 26 deletions src/sasctl/pzmm/write_json_files.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1677,6 +1677,34 @@ def create_requirements_json(
item[0] for item in package_and_version if not item[1]
]


IMPORT_TO_INSTALL_MAPPING = {
Copy link
Collaborator Author

@sababak sababak Oct 20, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Could the addition of this import to install mapping create some issues with backwards compatibility? I noticed that in the example files it directs users to manually change the import names for packages like sklearn.

Copy link
Collaborator

@smlindauer smlindauer Oct 23, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

No, I think we're good here, since it was a non-programmatic ask. If they go hunting to change something and find it's fixed, I doubt we'll get complaints.

# Data Science & ML Core
"sklearn": "scikit-learn",
"skimage": "scikit-image",
"cv2": "opencv-python",
"PIL": "Pillow",
# Data Formats & Parsing
"yaml": "PyYAML",
"bs4": "beautifulsoup4",
"docx": "python-docx",
"pptx": "python-pptx",
# Date & Time Utilities
"dateutil": "python-dateutil",
# Database Connectors
"MySQLdb": "MySQL-python",
"psycopg2": "psycopg2-binary",
# System & Platform
"win32api": "pywin32",
"win32com": "pywin32",
# Scientific Libraries
"Bio": "biopython",
}

# Map import names to their corresponding package installation names
package_and_version = [
(IMPORT_TO_INSTALL_MAPPING.get(name, name), version) for name, version in package_and_version
]

if create_requirements_txt:
requirements_txt = ""
Expand Down Expand Up @@ -1752,37 +1780,11 @@ def package_not_found_output(package_name, package_versions):
package_versions.append([package_name, None])
return package_versions


IMPORT_TO_INSTALL_MAPPING = {
# Data Science & ML Core
"sklearn": "scikit-learn",
"skimage": "scikit-image",
"cv2": "opencv-python",
"PIL": "Pillow",
# Data Formats & Parsing
"yaml": "PyYAML",
"bs4": "beautifulsoup4",
"docx": "python-docx",
"pptx": "python-pptx",
# Date & Time Utilities
"dateutil": "python-dateutil",
# Database Connectors
"MySQLdb": "MySQL-python",
"psycopg2": "psycopg2-binary",
# System & Platform
"win32api": "pywin32",
"win32com": "pywin32",
# Scientific Libraries
"Bio": "biopython",
}

package_and_version = []

for package in package_list:
try:
name = importlib.import_module(package)
package = IMPORT_TO_INSTALL_MAPPING.get(package, package)

try:
package_and_version.append([package, name.__version__])
except AttributeError:
Expand Down
Loading