Don't drain ring buffer if not needed

[sbooth]

No description provided.

[Copilot]

Pull request overview

Adjusts decoder-cancellation handling in AudioPlayer’s decoding thread to avoid requesting a ring-buffer drain when canceling decoders that have not yet been initialized, reducing unnecessary drain cycles and potential audible disruption.

Changes:

• Cache DecoderState flags once per iteration when processing cancellations.
• Only mark the ring buffer as stale on cancellation when the canceled decoder has completed initialization (needsInitialization is clear).

---

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

[github-actions]

Cpp-linter Review

Used clang-format v22.1.7

Click here for the full clang-format patch

diff --git a/Sources/CSFBAudioEngine/Player/AudioPlayer.mm b/Sources/CSFBAudioEngine/Player/AudioPlayer.mm
index 0efa545..11354d5 100644
--- a/Sources/CSFBAudioEngine/Player/AudioPlayer.mm
+++ b/Sources/CSFBAudioEngine/Player/AudioPlayer.mm
@@ -1190 +1190,2 @@ void sfb::AudioPlayer::processDecoders(std::stop_token stoken) noexcept {
-                if (bits::is_set_without(flags, DecoderState::Flags::cancelRequested, DecoderState::Flags::isCanceled)) {
+                if (bits::is_set_without(flags, DecoderState::Flags::cancelRequested,
+                                         DecoderState::Flags::isCanceled)) {

Have any feedback or feature suggestions? Share it here.

outdated suggestion

[Copilot]

Pull request overview

Copilot reviewed 1 out of 1 changed files in this pull request and generated 1 comment.

[Copilot]

Pull request overview

Copilot reviewed 1 out of 1 changed files in this pull request and generated no new comments.