Skip to content

Add noexcept#928

Merged
sbooth merged 2 commits into
mainfrom
noexcept-call
Jun 8, 2026
Merged

Add noexcept#928
sbooth merged 2 commits into
mainfrom
noexcept-call

Conversation

@sbooth

@sbooth sbooth commented Jun 8, 2026

Copy link
Copy Markdown
Owner

No description provided.

Copilot AI review requested due to automatic review settings June 8, 2026 00:30

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This PR updates several small RAII deleter functors used with std::unique_ptr in the metadata and encoder implementations, marking their call operators as noexcept to better reflect that the underlying destruction routines are non-throwing and to preserve noexcept guarantees in unique_ptr destruction paths.

Changes:

  • Mark cf_type_ref_deleter::operator() as noexcept in TagLib metadata files.
  • Mark encoder-related std::unique_ptr deleter call operators as noexcept for Opus, MP3 (LAME), and FLAC.

Reviewed changes

Copilot reviewed 6 out of 6 changed files in this pull request and generated no comments.

Show a summary per file
File Description
Sources/CSFBAudioEngine/Metadata/SFBAudioMetadata+TagLibXiphComment.mm Add noexcept to CFTypeRef unique_ptr deleter call operator.
Sources/CSFBAudioEngine/Metadata/SFBAudioMetadata+TagLibMP4Tag.mm Add noexcept to CFTypeRef unique_ptr deleter call operator.
Sources/CSFBAudioEngine/Metadata/SFBAudioMetadata+TagLibID3v2Tag.mm Add noexcept to CFTypeRef unique_ptr deleter call operator.
Sources/CSFBAudioEngine/Encoders/SFBOggOpusEncoder.mm Add noexcept to Opus encoder/comment deleter call operators.
Sources/CSFBAudioEngine/Encoders/SFBMP3Encoder.mm Add noexcept to LAME lame_global_flags deleter call operator.
Sources/CSFBAudioEngine/Encoders/SFBFLACEncoder.mm Add noexcept to FLAC encoder/metadata deleter call operators.

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

@sbooth sbooth changed the title Add noexcept to call operator Add noexcept Jun 8, 2026
@sbooth sbooth merged commit b38516e into main Jun 8, 2026
2 checks passed
@sbooth sbooth deleted the noexcept-call branch June 8, 2026 00:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants