Add noexcept to lambdas#930
Merged
Merged
Conversation
Contributor
There was a problem hiding this comment.
Pull request overview
This PR standardizes lambda exception specifications by adding explicit noexcept where appropriate and adjusting lambda syntax to the standard form required when specifying noexcept (i.e., adding () for empty parameter lists). This improves correctness/portability of the C++ code (especially around lambda declarators) and clarifies that certain callbacks/predicates are not expected to throw.
Changes:
- Fix lambda declarator syntax in
host_time.hppby adding an explicit empty parameter list beforenoexcept. - Mark
std::stop_callbacklambdas asnoexceptinAudioPlayer.mm. - Mark several internal predicate/helper lambdas as
noexceptinAudioPlayer.mm.
Reviewed changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated no comments.
| File | Description |
|---|---|
| Sources/CSFBAudioEngine/Player/host_time.hpp | Makes the timebase initialization lambda use standard []() noexcept {} syntax. |
| Sources/CSFBAudioEngine/Player/AudioPlayer.mm | Adds noexcept to several lambdas (stop callbacks and predicates) and updates syntax for empty-parameter lambdas accordingly. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.