Skip to content

Conversation

@estellesoulard
Copy link
Contributor

For terraform plugin framework schema attributes:

  • add custom soft validation with warning for locality (zone or region)
  • add strong UUID validation
  • add localized UUID validation

@estellesoulard estellesoulard requested review from a team and remyleone as code owners December 12, 2025 11:23
@github-actions github-actions bot added the instance Instance issues, bugs and feature requests label Dec 12, 2025
@codecov-commenter
Copy link

codecov-commenter commented Dec 12, 2025

Codecov Report

❌ Patch coverage is 42.62295% with 35 lines in your changes missing coverage. Please review.
✅ Project coverage is 1.72%. Comparing base (3d8e94d) to head (28f5df1).
✅ All tests successful. No failed tests found.

Files with missing lines Patch % Lines
internal/locality/regional/schemas_framework.go 0.00% 8 Missing ⚠️
internal/locality/zonal/schemas_framework.go 0.00% 7 Missing ⚠️
internal/verify/framework.go 81.25% 5 Missing and 1 partial ⚠️
...rvices/cockpit/action_trigger_test_alert_action.go 0.00% 4 Missing ⚠️
internal/services/instance/action_server_action.go 0.00% 4 Missing ⚠️
...al/services/keymanager/action_rotate_key_action.go 0.00% 4 Missing ⚠️
...ervices/jobs/action_start_job_definition_action.go 0.00% 2 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff            @@
##           master   #3532      +/-   ##
=========================================
+ Coverage    1.67%   1.72%   +0.04%     
=========================================
  Files         428     430       +2     
  Lines       46749   46794      +45     
=========================================
+ Hits          785     809      +24     
- Misses      45876   45895      +19     
- Partials       88      90       +2     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@estellesoulard estellesoulard force-pushed the chore/add-custom-framework-validators branch from d1a4138 to 93f7b53 Compare December 12, 2025 17:23
@estellesoulard estellesoulard force-pushed the chore/add-custom-framework-validators branch from 93f7b53 to d5242fc Compare December 12, 2025 17:25
remyleone
remyleone previously approved these changes Dec 15, 2025
@remyleone remyleone added this pull request to the merge queue Dec 15, 2025
@github-merge-queue github-merge-queue bot removed this pull request from the merge queue due to failed status checks Dec 15, 2025
@remyleone remyleone added this pull request to the merge queue Dec 15, 2025
github-merge-queue bot pushed a commit that referenced this pull request Dec 15, 2025
* chore(actions): add custom plugin-framework validation

* fix: review feedback
@github-merge-queue github-merge-queue bot removed this pull request from the merge queue due to failed status checks Dec 15, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

instance Instance issues, bugs and feature requests

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants