Fix ingestion from raft session >=10#2727
Fix ingestion from raft session >=10#2727francoisferrand wants to merge 1 commit intodevelopment/9.1from
Conversation
The JSON was causing the raftId string (which is the http body of the response) to be returned to the code as an array of string : [ '1', '3' ]. Which was worked-around by taking the first element. That fix worked for raft sesion < 10, but breaks when raft session cluster grows. The fix is to properly define the model, with the `payload` attribute allowing to indicate that the body of the request should map to a specified field of the model. Impact is limited since we only make a call to this API in a single place. Issue: BB-759
Hello francoisferrand,My role is to assist you with the merge of this Available options
Available commands
Status report is not available. |
|
LGTM |
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files
... and 1 file with indirect coverage changes
@@ Coverage Diff @@
## development/9.1 #2727 +/- ##
===================================================
- Coverage 74.81% 74.79% -0.03%
===================================================
Files 201 201
Lines 13529 13529
===================================================
- Hits 10122 10119 -3
- Misses 3397 3400 +3
Partials 10 10
Flags with carried forward coverage won't be shown. Click here to find out more. 🚀 New features to boost your workflow:
|
Request integration branchesWaiting for integration branch creation to be requested by the user. To request integration branches, please comment on this pull request with the following command: Alternatively, the |
SylvainSenechal
left a comment
There was a problem hiding this comment.
probably gonna have some nice conflict on waterfall
The JSON was causing the raftId string (which is the http body of the response) to be returned to
the code as an array of string : [ '1', '3' ]. Which was worked-around by taking the first element.
That fix worked for raft sesion < 10, but breaks when raft session cluster grows.
The fix is to properly define the model, with the
payloadattribute allowing to indicate that thebody of the request should map to a specified field of the model.
Impact is limited since we only make a call to this API in a single place.
Issue: BB-759