Avoid showing spinners in non tty env #117
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add shouldShowSpinner() utility that checks both Deno.stdout.isTerminal() and the NO_COLOR environment variable before showing spinners. This prevents garbled spinner output when the CLI is used with tools that capture output (e.g., AI assistants, scripts). Removes --no-color flags from commands where they only controlled spinner visibility, since spinners now automatically disable in non-TTY environments. Fixes #113
Updated bulk.ts to use the centralized shouldShowSpinner() function instead of directly checking Deno.stdout.isTerminal(). This ensures progress display during bulk operations also respects the NO_COLOR environment variable. Fixes #113
schpet
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
fix this issue #113
Details
run-1c3017ab