Merged
Conversation
antoniaelsen
reviewed
Nov 6, 2024
Contributor
|
I'm fine with updating NDTPPayloadBroadband in synapse-cpp, IMO the time would be now and we can uprev versions. Same with standardizing to 16bit. |
Contributor
|
lgtm, just needs those tests fixed |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The underlying representation of channel data in the
NDTPPayloadBroadbandstruct is currently a vector of uint64s. This is nice for flexible data widths, but few use cases (if any) will ever need 64 bits of sample precision. Changing the struct to a template allows for a smaller data type (namely 16-bit ints) to be used. This also means that the struct can be constructed without copying all of the sample data into a new vector, significantly improving construction time.My primary motivation for this change is improving performance of this data type without disrupting other library consumers. However the same performance bump could be gained by just universally agreeing to support bit widths only up to 16 bits. 64 bits is frankly kind of over the top.
The
NDTPPayloadBroadbandtype name is preserved as using 64-bit ints so not to break other library users.