Skip to content

Autocompletion fallback#556

Open
catreedle wants to merge 29 commits intoscribe-org:mainfrom
catreedle:autocompletion-fallback
Open

Autocompletion fallback#556
catreedle wants to merge 29 commits intoscribe-org:mainfrom
catreedle:autocompletion-fallback

Conversation

@catreedle
Copy link
Copy Markdown
Collaborator

@catreedle catreedle commented Mar 6, 2026

Contributor checklist


Description

Add fallback autocompletion from nouns table when autocomplete lexicon Trie is unavailable.

  • Changes in AutocompletionDataManager functions to handle fallback, loadWords function loads and caches all the nouns distinctly for autocompletion
  • Fix db name in DynamicDbHelper
  • Small change in GeneralKeyboardIME to pass the column names of nouns to loadWords

Related issue

@github-actions
Copy link
Copy Markdown

github-actions bot commented Mar 6, 2026

Thank you for the pull request! 💙

The Scribe-Android team will do our best to address your contribution as soon as we can. If you're not already a member of our public Matrix community, please consider joining! We'd suggest that you use the Element client as well as Element X for a mobile app, and definitely join the General and Android rooms once you're in. Also consider attending our bi-weekly Saturday dev syncs. It'd be great to meet you 😊

Note

Scribe uses Conventional Comments in reviews to make sure that communication is as clear as possible.

@github-actions
Copy link
Copy Markdown

github-actions bot commented Mar 6, 2026

Maintainer Checklist

The following is a checklist for maintainers to make sure this process goes as well as possible. Feel free to address the points below yourself in further commits if you realize that actions are needed :)

  • Tests for changes have been written and the unit test, linting and formatting workflows within the PR checks do not indicate new errors in the files changed

    • Tests may need to be reran as they're at times not deterministic
  • The CHANGELOG has been updated with a description of the changes for the upcoming release and the corresponding issue (if necessary)

@andrewtavis
Copy link
Copy Markdown
Member

Quick note from the review with @catreedle: We're seeing that the words in the autocompletion are lower case. Would be great if these would match the capitalization of the keyboard as well as the capitalization of the word in cases like German nouns and proper nouns :)

@catreedle
Copy link
Copy Markdown
Collaborator Author

autocomplete.webm

hi @andrewtavis
Please have a look and let me know if this works as expected or adjustment is needed. :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Use nouns table for alphabetical autocompletions

2 participants