Conversation
Thank you for the pull request! 💙The Scribe-Data team will do our best to address your contribution as soon as we can. If you're not already a member of our public Matrix community, please consider joining! We'd suggest that you use the Element client as well as Element X for a mobile app, and definitely join the Note Scribe uses Conventional Comments in reviews to make sure that communication is as clear as possible. |
Maintainer ChecklistThe following is a checklist for maintainers to make sure this process goes as well as possible. Feel free to address the points below yourself in further commits if you realize that actions are needed :) |
There was a problem hiding this comment.
First PR Commit Check
- The commit messages for the remote branch of a new contributor should be checked to make sure their email is set up correctly so that they receive credit for their contribution
- The contributor's name and icon in remote commits should be the same as what appears in the PR
- If there's a mismatch, the contributor needs to make sure that the email they use for GitHub matches what they have for
git config user.emailin their local Scribe-Data repo (can be set withgit config --global user.email "GITHUB_EMAIL")
|
Thanks for the PR here, @etidoukpong-spec! To your question, as the contracts could change from one export to the next, I think the best functionality would be to check with the user on if they should be exported or not, and if so then we overwrite the directory without a rename. Feel free to send along a change to fix that and then mark this as ready for review! |
|
Thanks @andrewtavis, I will see what I can do! |
Contributor checklist
pytestcommand as directed in the testing section of the contributing guideDescription
main.pycontracts/export.pyQuestion on Overwrite Behavior:
Currently, if a contracts/ folder already exists in the PWD, the export_contracts command alerts the user and stops to prevent accidental overwriting of their data.
What is the most useful behaviour?
Related issue