Skip to content

test: add missing tests for data_to_sqlite (#623)#676

Open
keerthanakh89 wants to merge 1 commit intoscribe-org:mainfrom
keerthanakh89:feature/add-missing-tests
Open

test: add missing tests for data_to_sqlite (#623)#676
keerthanakh89 wants to merge 1 commit intoscribe-org:mainfrom
keerthanakh89:feature/add-missing-tests

Conversation

@keerthanakh89
Copy link
Copy Markdown

Fixes #623

Tests Added

  • test_create_table_empty_columns
  • test_table_insert_empty_values
  • test_create_table_preserves_numbers
  • test_data_to_sqlite_multiple_languages
  • test_data_to_sqlite_specific_tables
  • test_data_to_sqlite_empty_language_list
  • test_translations_to_sqlite_empty_data
  • test_translations_to_sqlite_last_modified_missing
  • test_data_to_sqlite_relative_path
  • TestTableInsertSpecialCharacters class
  • test_data_to_sqlite_preserves_existing_data

@github-actions
Copy link
Copy Markdown
Contributor

Thank you for the pull request! 💙🩵

The Scribe-Data team will do our best to address your contribution as soon as we can. The following are some important points:

  • Those interested in developing their skills and expanding their role in the community should read the mentorship and growth section of the contribution guide
  • If you're not already a member of our public Matrix community, please consider joining!
    • We'd suggest that you use the Element client as well as Element X for a mobile app
    • Join the General and Data rooms once you're in
  • Also consider attending our bi-weekly Saturday developer syncs!
    • Details are shared in the General room on Matrix each Wednesday before the sync
    • It would be great to meet you 😊

Note

Scribe uses Conventional Comments in reviews to make sure that communication is as clear as possible.

@github-actions
Copy link
Copy Markdown
Contributor

Maintainer Checklist

The following is a checklist for maintainers to make sure this process goes as well as possible. Feel free to address the points below yourself in further commits if you realize that actions are needed :)

  • Tests for changes have been written and the pytest, linting and formatting workflows within the PR checks do not indicate new errors in the files changed

  • The CHANGELOG has been updated with a description of the changes for the upcoming release and the corresponding issue (if necessary)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[Multiple assignees possible] Add missing tests to Scribe-Data

1 participant