Skip to content

Fix: resolve no-untyped-call and no-untyped-def #681

Merged
andrewtavis merged 3 commits intoscribe-org:mainfrom
ashb155:fix/no-untyped-call
Apr 4, 2026
Merged

Fix: resolve no-untyped-call and no-untyped-def #681
andrewtavis merged 3 commits intoscribe-org:mainfrom
ashb155:fix/no-untyped-call

Conversation

@ashb155
Copy link
Copy Markdown
Contributor

@ashb155 ashb155 commented Mar 31, 2026

Contributor checklist


Description

Description

This PR adds missing return type and parameter type annotations across all test files to resolve no-untyped-def and no-untyped-call mypy errors throughout the codebase.

Files changed:

  • tests/check/test_check_project_metadata.py — annotated test functions
  • tests/cli/contracts/ — annotated functions across test_contracts_check.py and test_contracts_export.py; added MagicMock, Path, and Any imports
  • tests/cli/ — annotated functions across test_convert.py, test_download.py, test_dump.py, test_get.py, test_interactive.py, test_list.py, test_total.py, test_upgrade.py, test_utils.py, and test_version.py; added MagicMock imports
  • tests/load/ — annotated fixtures and test functions in test_data_to_sqlite.py and test_update_utils.py; added Path and Any imports
  • tests/resources/test_metadata.py — annotated helper and test functions with pathlib.Path parameter types
  • tests/unicode/test_generate_emoji_keywords.py — annotated fixtures and test functions with Iterator, MagicMock, Path types
  • tests/wikidata/ — annotated functions across test_check_query.py and test_query_data.py; added MagicMock imports
  • Ensured Ruff formatting on changes to ensure compliance with project standards

Testing: Ran pytest and verified no remaining errors with mypy . --enable-error-code no-untyped-def and mypy . --enable-error-code no-untyped-call

image

Related issue

@github-actions
Copy link
Copy Markdown
Contributor

Thank you for the pull request! 💙🩵

The Scribe-Data team will do our best to address your contribution as soon as we can. The following are some important points:

  • Those interested in developing their skills and expanding their role in the community should read the mentorship and growth section of the contribution guide
  • If you're not already a member of our public Matrix community, please consider joining!
    • We'd suggest that you use the Element client as well as Element X for a mobile app
    • Join the General and Data rooms once you're in
  • Also consider attending our bi-weekly Saturday developer syncs!
    • Details are shared in the General room on Matrix each Wednesday before the sync
    • It would be great to meet you 😊

Note

Scribe uses Conventional Comments in reviews to make sure that communication is as clear as possible.

@github-actions
Copy link
Copy Markdown
Contributor

github-actions bot commented Mar 31, 2026

Maintainer Checklist

The following is a checklist for maintainers to make sure this process goes as well as possible. Feel free to address the points below yourself in further commits if you realize that actions are needed :)

  • Tests for changes have been written and the pytest, linting and formatting workflows within the PR checks do not indicate new errors in the files changed

  • The CHANGELOG has been updated with a description of the changes for the upcoming release and the corresponding issue (if necessary)

@andrewtavis andrewtavis self-requested a review April 4, 2026 10:21
Copy link
Copy Markdown
Member

@andrewtavis andrewtavis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the PR, @ashb155! Feel free to remove the error from disable_error_code in pyproject.toml for future PRs 😊

@andrewtavis andrewtavis merged commit f70fcc7 into scribe-org:main Apr 4, 2026
6 checks passed
@ashb155 ashb155 deleted the fix/no-untyped-call branch April 4, 2026 17:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants