Fix: resolve no-untyped-call and no-untyped-def #681
Merged
andrewtavis merged 3 commits intoscribe-org:mainfrom Apr 4, 2026
Merged
Fix: resolve no-untyped-call and no-untyped-def #681andrewtavis merged 3 commits intoscribe-org:mainfrom
andrewtavis merged 3 commits intoscribe-org:mainfrom
Conversation
Contributor
Thank you for the pull request! 💙🩵The Scribe-Data team will do our best to address your contribution as soon as we can. The following are some important points:
Note Scribe uses Conventional Comments in reviews to make sure that communication is as clear as possible. |
Contributor
Maintainer ChecklistThe following is a checklist for maintainers to make sure this process goes as well as possible. Feel free to address the points below yourself in further commits if you realize that actions are needed :) |
andrewtavis
approved these changes
Apr 4, 2026
Member
andrewtavis
left a comment
There was a problem hiding this comment.
Thanks for the PR, @ashb155! Feel free to remove the error from disable_error_code in pyproject.toml for future PRs 😊
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Contributor checklist
pytestcommand as directed in the testing section of the contributing guideDescription
Description
This PR adds missing return type and parameter type annotations across all test files to resolve
no-untyped-defandno-untyped-callmypy errors throughout the codebase.Files changed:
tests/check/test_check_project_metadata.py— annotated test functionstests/cli/contracts/— annotated functions acrosstest_contracts_check.pyandtest_contracts_export.py; addedMagicMock,Path, andAnyimportstests/cli/— annotated functions acrosstest_convert.py,test_download.py,test_dump.py,test_get.py,test_interactive.py,test_list.py,test_total.py,test_upgrade.py,test_utils.py, andtest_version.py; addedMagicMockimportstests/load/— annotated fixtures and test functions intest_data_to_sqlite.pyandtest_update_utils.py; addedPathandAnyimportstests/resources/test_metadata.py— annotated helper and test functions withpathlib.Pathparameter typestests/unicode/test_generate_emoji_keywords.py— annotated fixtures and test functions withIterator,MagicMock,Pathtypestests/wikidata/— annotated functions acrosstest_check_query.pyandtest_query_data.py; addedMagicMockimportsTesting: Ran
pytestand verified no remaining errors withmypy . --enable-error-code no-untyped-defandmypy . --enable-error-code no-untyped-callRelated issue