Open
Conversation
It's best practice to not modify the source during a build so a single source folder can be used to build multiple variations. Especially with WSL on Windows this makes it very easy to verify code changes work even across platforms.
Building the unit tests on Windows failed at the linking stage:
LINK : fatal error LNK1104: cannot open file 'scylla-cpp-driver_static.lib'
This is caused by the tests being forced to use the static library on
Windows but link against `${PROJECT_LIB_NAME_TARGET}` which is set to
`scylla-cpp-driver_static` in the main `CMakeLists.txt` while the target
was actually still called `cassandra_static`.
Renamed the static library target to be consistent with the dynamic
library target and `${PROJECT_LIB_NAME_TARGET}` so the tests can be
successfully linked on Windows.
The test failed with: tests/src/unit/tests/test_protocol_version.cpp:33: Failure Expected: ProtocolVersion(CASS_PROTOCOL_VERSION_DSEV2) Which is: 4-byte object <42-00 00-00> To be equal to: ProtocolVersion::highest_supported() Which is: 4-byte object <04-00 00-00> This most likely broke with 9d37d1b where the default value of the parameter changed. Changed the expected value to match what the function now returns since the mentioned commit looks like it intentionally changed that value.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
As promised in #81 I've looked into running the tests on Windows.
Only c3c6000 is strictly necessary. The other two commits are just something easy to fix.