Conversation
Add distributed tracing using OpenTelemetry with OTLP gRPC exporter. Instruments HTTP handlers (otelhttp), gRPC servers (otelgrpc), and outbound CT log HTTP client. Tracing is controlled via CLI flags. Uses the shared tracing library from sigstore/model-validation-operator. Signed-off-by: Nina Bongartz <nolear@redhat.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
--tracing-enabled,--tracing-endpoint,--tracing-insecure,--tracing-stdoutotelhttp.NewHandlerfor automatic span creationotelgrpc.NewServerHandler()(main, legacy, and duplex)otelhttp.NewTransportsigstore/model-validation-operator/pkg/tracingChanges
cmd/app/serve.go: Add tracing flags, init, and CT log transport wrappingcmd/app/grpc.go: Add otelgrpc to main and legacy gRPC serverscmd/app/http.go: Wrap HTTP handler with otelhttpgo.mod/go.sum: Add tracing dependenciesTest plan
--tracing-enabled --tracing-endpoint <collector>and verify traces in Jaeger