Merged
Conversation
|
The latest Buf updates on your PR. Results from workflow Buf / buf (pull_request).
|
Codecov Report❌ Patch coverage is Additional details and impacted files@@ Coverage Diff @@
## main #3109 +/- ##
==========================================
- Coverage 58.60% 58.59% -0.01%
==========================================
Files 2096 2098 +2
Lines 173400 173535 +135
==========================================
+ Hits 101621 101686 +65
- Misses 62739 62795 +56
- Partials 9040 9054 +14
Flags with carried forward coverage won't be shown. Click here to find out more.
🚀 New features to boost your workflow:
|
philipsu522
approved these changes
Mar 23, 2026
| # HTTP 200; gate errors: JSON-RPC error (data legacy_sei_deprecated). Success: unchanged body; optional header Sei-Legacy-RPC-Deprecation. | ||
| # Same allowlist as docker/localnode (all gated methods except sei_sign for integration coverage). | ||
| enabled_legacy_sei_apis = [ | ||
| # "sei_sign" |
Contributor
Author
There was a problem hiding this comment.
I left it here intentionally commented to show explicitly that this one is not enabled. we can remove it as well. no worries.
| # disabled-method path; sei_sign is not in partner telemetry and has no rpc_io_test fixtures). | ||
| # Production defaults from seid init remain the three-method sei_* allowlist - see evmrpc/config. | ||
| enabled_legacy_sei_apis = [ | ||
| # "sei_sign", |
jewei1997
approved these changes
Mar 23, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Describe your changes and provide context
This PR proposes a flag for deprecated sei RPCs.
It deprecates legacy
sei_* / sei2_*JSON-RPC on the EVM HTTP surface. Access is controlled by[evm].enabled_legacy_sei_apisinapp.toml; enforcement is centralized inwrapSeiLegacyHTTP (sei_legacy_http.go)so handlers don't duplicate gate logic.Behavior:
Methods not in the allowlist: HTTP 200, JSON-RPC
error (-32601), message explains disabled + deprecated, data:legacy_sei_deprecated.Methods in the allowlist: response body unchanged; optional HTTP header
Sei-Legacy-RPC-Deprecationon success so clients can detect legacy usage.Config / defaults
seid init/ template documents the allowlist; docker localnet enables gated methods broadly (sei_signleft off by default for testing purposes).HTTPConfig.SeiLegacyAllowlist wires the list from app config into the server.
Related issues: https://linear.app/seilabs/issue/PLT-148/epic-audit-and-deprecation-plan-for-sei-rpc-endpoints