Fix download_things.sh: pass password to unzip#12
Open
c-mulliken wants to merge 1 commit into
Open
Conversation
The THINGS OSF archive is password-protected, but the script called `unzip` with no password, so the download always failed at the unzip step. Pass the (public) password `things4all`, overridable via THINGS_ZIP_PASSWORD, and add `set -euo pipefail` so a failed fetch/unzip aborts instead of `rm`-ing a partial/again-missing archive. Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
The THINGS OSF archive (
images_THINGS.zip, projectjum2f) is password-protected, butscripts/download_things.shranunzip images_THINGS.zipwith no password — so the download step always failed at unzip, thenrm'd the archive. Confirmed while pulling the data to Oscar: the fetch succeeds (5.02 GB) but the stock script cannot unpack it.Fix
things4alltounzip -P, overridable viaTHINGS_ZIP_PASSWORD.set -euo pipefailso a failed fetch/unzip aborts instead of proceeding torma missing/partial archive.unzip -oto overwrite cleanly on re-runs.Verified end-to-end on Oscar: fetch +
unzip -P things4allunpacks todata/THINGS/object_images/(1,854 concept folders, 26,107 images).🤖 Generated with Claude Code