Skip to content

optimize conversion #329

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
decanus wants to merge 1 commit into
base: master
Choose a base branch
from
+1 −4
Open

optimize conversion #329

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 1 addition & 4 deletions decimal.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -967,10 +967,7 @@ func (d Decimal) IntPart() int64 {

// BigInt returns integer component of the decimal as a BigInt.
func (d Decimal) BigInt() *big.Int {
scaledD := d.rescale(0)
i := &big.Int{}
i.SetString(scaledD.String(), 10)
return i
return new(big.Int).Set(d.value)

@serprex serprex Apr 3, 2024 •
edited
Loading

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
return new(big.Int).Set(d.value)
scaledD := d.rescale(0)
return new(big.Int).Set(scaledD.value)

@mwoss this corrects your feedback. btw, why does rescale need to return a new Decimal when exp == d.exp? would expect with non-mutable API it'd be fine to return d

ofc, with d.rescale always allocating a fresh bigint, it'd be safe to return scaledD.value itself

@serprex serprex Apr 4, 2024

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Created #359

@mwoss mwoss Apr 4, 2024

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for working on that :D

btw, why does rescale need to return a new Decimal when exp == d.exp? would expect with non-mutable API it'd be fine to return d

If I remember correctly we have done it because, in a few places in the codebase, we expect that rescale always returns a new decimal, so we can safely perform operations on d.value. It could be improved for sure, but we would need to track down all those places and safely update the code and docs.

}

// BigFloat returns decimal as BigFloat.
Expand Down