SG-38126 Review and Fixups CI Tests and Code Coverage#73
SG-38126 Review and Fixups CI Tests and Code Coverage#73julien-lang merged 14 commits intomasterfrom
Conversation
There was a problem hiding this comment.
Pull request overview
This PR enhances the CI/CD pipeline's code coverage reporting and test execution infrastructure. It modernizes the testing workflow by replacing pytest-azurepipelines with explicit pytest plugins, implements OS-specific codecov uploader URLs, and consolidates coverage upload logic across all platforms.
Changes:
- Replaced
pytest-azurepipelineswith individual pytest plugins (pytest,pytest-cov,pytest-nunit) - Added OS-specific codecov download URLs to centralize platform handling
- Unified code coverage upload workflow using Azure Pipeline tasks instead of OS-specific bash/powershell scripts
Reviewed changes
Copilot reviewed 3 out of 3 changed files in this pull request and generated 3 comments.
| File | Description |
|---|---|
| internal/run-tests.yml | Added codecov download URLs for each OS platform with macOS pinned to v0.7.3 due to architecture constraints |
| internal/run-tests-with.yml | Refactored test execution and coverage reporting to use unified Azure Pipeline tasks and explicit pytest plugins |
| README.md | Added codecov.io coverage status badge |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
carlos-villavicencio-adsk
left a comment
There was a problem hiding this comment.
LGTM. Although I shared some questions here and there.
| QT_QPA_PLATFORM: offscreen | ||
| DISPLAY: ':99.0' | ||
|
|
||
| TK_DEBUG: 1 |
| displayName: Publish code coverage | ||
| inputs: | ||
| summaryFileLocation: coverage.xml | ||
| failIfCoverageEmpty: true |
There was a problem hiding this comment.
Is this going to affect any other repos where coverage is not updated yet?
There was a problem hiding this comment.
All repos using tk-ci-tools will generate coverage because the command is made in this same file.
If the repos does not have a tests/ folder, then, this playbook is not called.
| vm_image: macOS-14 | ||
| codecov_download_url: https://uploader.codecov.io/v0.7.3/macos/codecov | ||
| # macOS & codecov note: | ||
| # In Nov 2024 (SG-36700), we pinned macOS to codecov v0.7.3 because the |
There was a problem hiding this comment.
It's also worth considering mentioning SG-36012 as well.
Improve Test Results and Code Coverage reports. Make sure they are properly passed to Azure Pipelines and Codecov.io
Align with other repositories:
Implemented by:
Azure Pipeline CI Improvements