Skip to content

Conversation

@pmachapman
Copy link
Collaborator

@pmachapman pmachapman commented Jan 28, 2026

This PR helps the SignalR server and client to reconnect and resend any missed messages if the connection is interrupted for some reason, such as connectivity issues.

I have also cherrypicked a commit from #3638 that will unsubscribed from notifications, to ensure that the server does not remember messages for clients that no longer require SignalR notifications for a sync or draft.


This change is Reviewable

@codecov
Copy link

codecov bot commented Jan 28, 2026

Codecov Report

❌ Patch coverage is 40.00000% with 9 lines in your changes missing coverage. Please review.
✅ Project coverage is 83.28%. Comparing base (d46a077) to head (70eb3c6).
✅ All tests successful. No failed tests found.

Files with missing lines Patch % Lines
src/SIL.XForge.Scripture/Startup.cs 0.00% 4 Missing ⚠️
...ntApp/src/app/core/project-notification.service.ts 0.00% 3 Missing ⚠️
.../app/sync/sync-progress/sync-progress.component.ts 75.00% 1 Missing ⚠️
...draft-history-list/draft-history-list.component.ts 75.00% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##           master    #3655      +/-   ##
==========================================
- Coverage   83.29%   83.28%   -0.01%     
==========================================
  Files         611      611              
  Lines       37646    37655       +9     
  Branches     6182     6158      -24     
==========================================
+ Hits        31358    31362       +4     
- Misses       5332     5350      +18     
+ Partials      956      943      -13     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants