fix: guard empty aliases list in 'llm aliases list' - #1604
Open
abhi-0203 wants to merge 1 commit into
Open
Conversation
The plain text path of 'llm aliases list' called max() on an empty sequence when no aliases were defined, raising ValueError. The --json variant already handled this correctly. Add an early return when no aliases exist, matching the --json path's behavior. Closes simonw#1602
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Fixes a
ValueError: max() arg is an empty sequencewhen runningllm aliases liston a fresh install or after removing all aliases.The
--jsonvariant already handles the empty case correctly (returns{}), but the plain text path callsmax()on an empty sequence before checking whether there is anything to display.Fix
Add an early return when no aliases exist, before the
max()call. This matches the--jsonpath's behavior.Reproduction
Closes #1602