-
Notifications
You must be signed in to change notification settings - Fork 3.2k
fix(copilot): rewrote user input popover to optimize UX #2814
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for GitHub. |
Contributor
Greptile SummaryThis PR consolidates the user input popover implementation by introducing a config-driven factory pattern for mention and slash menus. Key improvements:
Confidence Score: 5/5
Important Files Changed
Sequence DiagramsequenceDiagram
participant User
participant UserInput
participant MentionMenu
participant PopoverContext
participant FOLDER_CONFIGS
participant useMentionKeyboard
participant useMentionInsertHandlers
participant Utils
User->>UserInput: Type `@` character
UserInput->>MentionMenu: Show mention menu
MentionMenu->>PopoverContext: Initialize context
MentionMenu->>FOLDER_CONFIGS: Get folder configurations
FOLDER_CONFIGS-->>MentionMenu: Return folder configs (chats, workflows, etc.)
MentionMenu->>User: Display root menu items
User->>UserInput: Type query after `@`
UserInput->>MentionMenu: Update with query
MentionMenu->>FOLDER_CONFIGS: Filter items using config.filterFn
MentionMenu->>User: Show aggregated search results
User->>UserInput: Press ArrowRight on folder
UserInput->>useMentionKeyboard: handleArrowRight
useMentionKeyboard->>PopoverContext: openFolder(folderId, title)
PopoverContext-->>MentionMenu: Update currentFolder state
MentionMenu->>Utils: getFolderData(folderId)
Utils->>FOLDER_CONFIGS: Access config.dataKey
Utils-->>MentionMenu: Return folder items
MentionMenu->>User: Display folder contents
User->>UserInput: Select item (Enter/Click)
UserInput->>useMentionKeyboard: handleEnterSelection
useMentionKeyboard->>useMentionInsertHandlers: Call insert handler
useMentionInsertHandlers->>FOLDER_CONFIGS: Get config.buildContext
FOLDER_CONFIGS-->>useMentionInsertHandlers: Return context builder
useMentionInsertHandlers->>Utils: isContextAlreadySelected
Utils-->>useMentionInsertHandlers: Validate not duplicate
useMentionInsertHandlers->>UserInput: replaceActiveMentionWith(label)
useMentionInsertHandlers->>UserInput: onContextAdd(context)
useMentionInsertHandlers->>PopoverContext: closeFolder()
MentionMenu->>User: Hide menu, insert `@label`
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Type of Change
Testing
Tested manually
Checklist