Skip to content

Conversation

@waleedlatif1
Copy link
Collaborator

Summary

  • update translations action to run once per week on sunday
  • add dummy DATABASE_URL to prevent verify-translations job from failing

Type of Change

  • Bug fix

Testing

Tested manually

Checklist

  • Code follows project style guidelines
  • Self-reviewed my changes
  • Tests added/updated and passing
  • No new warnings introduced
  • I confirm that I have read and agree to the terms outlined in the Contributor License Agreement (CLA)

@vercel
Copy link

vercel bot commented Jan 14, 2026

The latest updates on your projects. Learn more about Vercel for GitHub.

Project Deployment Review Updated (UTC)
docs Ready Ready Preview, Comment Jan 14, 2026 7:15pm

@greptile-apps
Copy link
Contributor

greptile-apps bot commented Jan 14, 2026

Greptile Summary

This PR changes the i18n workflow from a push-triggered model (runs when documentation files change on staging) to a scheduled weekly model (runs every Sunday at midnight UTC). The changes include adding a dummy DATABASE_URL environment variable to prevent build verification failures.

Key changes:

  • Workflow trigger changed from push-based to schedule-based (cron: 0 0 * * 0)
  • Added workflow_dispatch for manual triggers
  • Added explicit ref: staging to the translate job checkout
  • Added dummy PostgreSQL credentials for build verification step
  • Updated PR descriptions to reflect weekly scheduled runs instead of push-triggered runs
  • Updated PR branch naming from staging-merge to weekly pattern

Issues found:

  • The verify-translations job lost the explicit ref: staging checkout specification that was present in the previous version, which could cause branch mismatch issues if repository defaults change

Confidence Score: 3/5

  • This PR has a regression bug that needs to be fixed before merging - the verify-translations job is missing the explicit branch ref specification.
  • The workflow changes are generally sensible (moving to scheduled runs), but there's a clear regression: the verify-translations job checkout lost the ref: staging specification that was present in the previous version. This inconsistency could lead to the job checking out the wrong branch, defeating the purpose of explicitly pinning the staging branch in the translate job. The dummy DATABASE_URL addition is reasonable for preventing build failures but the missing branch ref is a logical error that needs correction.
  • .github/workflows/i18n.yml - verify-translations job checkout needs ref: staging added back

Important Files Changed

Filename Overview
.github/workflows/i18n.yml Workflow updated to run on a schedule (Sunday weekly) instead of on push. Changes include updating trigger mechanism, adding DATABASE_URL environment variable for build verification, and updating PR descriptions. However, the verify-translations job lost the explicit ref: staging checkout specification, which was present in the previous version and could cause issues.

Copy link
Contributor

@greptile-apps greptile-apps bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Additional Comments (1)

  1. .github/workflows/i18n.yml, line 120-123 (link)

    logic: The verify-translations job's checkout is missing ref: staging. The previous version (commit 51477c1) had this specified. Without it, the job may check out the wrong branch if the default branch changes, causing inconsistency with the translate job which explicitly checks out staging.

1 file reviewed, 1 comment

Edit Code Review Agent Settings | Greptile

@waleedlatif1 waleedlatif1 merged commit d7e0d9b into staging Jan 14, 2026
11 checks passed
@waleedlatif1 waleedlatif1 deleted the fix/i18n branch January 14, 2026 19:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants