Skip to content

🎨 Palette: Add loading states to async auth buttons #184

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
singhaditya21 wants to merge 1 commit into
base: main
Choose a base branch
from
Open

🎨 Palette: Add loading states to async auth buttons #184

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 3 additions & 0 deletions .Jules/palette.md
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,3 @@
## 2026-07-02 - Adding loading states to async auth buttons
**Learning:** Auth forms in vanilla JS apps often lack automatic button disabling and visual loading states during API requests, leading to potential duplicate submissions and poor feedback.
**Action:** Consistently use e.submitter and try/finally blocks to manage button disabled states, opacity, and loading text during async network requests.
91 changes: 67 additions & 24 deletions web-demo/js/app.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -65,7 +65,7 @@ class ClimaAI {

setupEventListeners() {
// Auth
document.getElementById('googleSignInBtn').addEventListener('click', () => this.handleGoogleSignIn());
document.getElementById('googleSignInBtn').addEventListener('click', (e) => this.handleGoogleSignIn(e));
document.getElementById('loginForm').addEventListener('submit', (e) => this.handleLogin(e));
document.getElementById('registerForm').addEventListener('submit', (e) => this.handleRegister(e));
document.getElementById('showRegister').addEventListener('click', (e) => {
Expand Down Expand Up @@ -145,6 +145,14 @@ class ClimaAI {
const email = document.getElementById('loginEmail').value;
const password = document.getElementById('loginPassword').value;

let originalText = '';
if (e.submitter) {
e.submitter.disabled = true;
originalText = e.submitter.innerHTML;
e.submitter.innerHTML = '⏳ Loading...';
e.submitter.style.opacity = '0.7';
}

try {
this.showToast('Logging in...', 'info');
const response = await api.login(email, password);
Expand All @@ -155,6 +163,12 @@ class ClimaAI {
this.checkSubscription();
} catch (error) {
this.showToast(error.message || 'Login failed', 'error');
} finally {
if (e.submitter) {
e.submitter.disabled = false;
e.submitter.innerHTML = originalText;
e.submitter.style.opacity = '1';
}
}
}

Expand All @@ -164,6 +178,14 @@ class ClimaAI {
const email = document.getElementById('registerEmail').value;
const password = document.getElementById('registerPassword').value;

let originalText = '';
if (e.submitter) {
e.submitter.disabled = true;
originalText = e.submitter.innerHTML;
e.submitter.innerHTML = '⏳ Loading...';
e.submitter.style.opacity = '0.7';
}

try {
this.showToast('Creating account...', 'info');
const response = await api.register(email, password, name);
Expand All @@ -174,6 +196,12 @@ class ClimaAI {
this.checkSubscription();
} catch (error) {
this.showToast(error.message || 'Registration failed', 'error');
} finally {
if (e.submitter) {
e.submitter.disabled = false;
e.submitter.innerHTML = originalText;
e.submitter.style.opacity = '1';
}
}
}

Expand All @@ -185,7 +213,16 @@ class ClimaAI {
this.showToast('Logged out successfully', 'info');
}

async handleGoogleSignIn() {
async handleGoogleSignIn(e) {
let originalText = '';
const targetBtn = e ? (e.currentTarget || e.target) : document.getElementById('googleSignInBtn');
if (targetBtn) {
targetBtn.disabled = true;
originalText = targetBtn.innerHTML;
targetBtn.innerHTML = '⏳ Loading...';
targetBtn.style.opacity = '0.7';
}

try {
this.showToast('🔐 Signing in with Google...', 'info');

Expand All @@ -197,31 +234,37 @@ class ClimaAI {
// 5. Backend creates/updates user and returns JWT

// For demo purposes, we'll simulate successful OAuth with demo account
setTimeout(async () => {
try {
// Auto-login with demo account
const response = await api.login('demo@climaai.com', 'Test1234');
this.user = response.user;
this.showToast('✅ Welcome! Signed in with Google', 'success');
this.showScreen('homeScreen');
this.loadWeatherData();
this.checkSubscription();
} catch (error) {
this.showToast('Google Sign-In succeeded! Welcome!', 'success');
// Create a demo user object
this.user = {
email: 'google-user@gmail.com',
full_name: 'Google User',
is_premium: true
};
this.isPremium = true;
this.showScreen('homeScreen');
this.loadWeatherData();
}
}, 1500); // Simulate OAuth redirect delay
await new Promise(resolve => setTimeout(resolve, 1500)); // Simulate OAuth redirect delay

try {
// Auto-login with demo account
const response = await api.login('demo@climaai.com', 'Test1234');
this.user = response.user;
this.showToast('✅ Welcome! Signed in with Google', 'success');
this.showScreen('homeScreen');
this.loadWeatherData();
this.checkSubscription();
} catch (error) {
this.showToast('Google Sign-In succeeded! Welcome!', 'success');
// Create a demo user object
this.user = {
email: 'google-user@gmail.com',
full_name: 'Google User',
is_premium: true
};
this.isPremium = true;
this.showScreen('homeScreen');
this.loadWeatherData();
}

} catch (error) {
this.showToast(error.message || 'Google Sign-In failed', 'error');
} finally {
if (targetBtn) {
targetBtn.disabled = false;
targetBtn.innerHTML = originalText;
targetBtn.style.opacity = '1';
}
}
}

Expand Down