[MNT] temporary fix for yellowbrick incompatibility with matplotlib >= 3.11 - #55
Open
siddharth7113 wants to merge 2 commits into
Open
[MNT] temporary fix for yellowbrick incompatibility with matplotlib >= 3.11#55siddharth7113 wants to merge 2 commits into
siddharth7113 wants to merge 2 commits into
Conversation
…= 3.11 Restores matplotlib.cm.get_cmap (removed in matplotlib 3.11, still called by yellowbrick) in pycaret.internal.patches.yellowbrick, no-op on older matplotlib. Raises the matplotlib upper bound to <3.12; the cooks plot remains guarded on matplotlib >= 3.8.
fkiraly
requested changes
Aug 9, 2026
fkiraly
left a comment
fkiraly
left a comment
Contributor
There was a problem hiding this comment.
This fix modifies the runtime environment and hence will be prone to side effects.
I think this should not be done. If we do this, it should at most be a localized monkeypatch that does not impact use of matplotlib outside the call locus.
Contributor
Author
Yeah, make sense, would make the edits. |
Contributor
Author
|
I don't know how , but I am overjoyed by the fact that CI and tests are passing. :) |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Temporary fix for #49.
matplotlib.cm.get_cmap, which yellowbrick still calls (yellowbrick.style.colors,yellowbrick.features.base). This restores the alias inpycaret.internal.patches.yellowbrick.<3.12. The old<3.8cap for py<3.13 was for thecooksplot, which remains via the existingNotImplementedErroron matplotlib >= 3.8.Verified locally: full plotting suite (22 tests) passes with matplotlib 3.11.1 forced. Note that CI's
[full]env still resolves matplotlib to 3.10.0 becauseydata-profilingcapsmatplotlib<=3.10, so 3.11 is only reachable in core installs.Heads-up for the follow-up: yellowbrick also uses
ListedColormap(N=...), deprecated since matplotlib 3.11 and scheduled for removal in 3.13.