Skip to content

[ENH] Add v2 support for DecoderMLP - closes #2076#2225

Draft
BLVCK-MAMBA-6 wants to merge 5 commits into
sktime:mainfrom
BLVCK-MAMBA-6:feature/decodermlp-v2
Draft

[ENH] Add v2 support for DecoderMLP - closes #2076#2225
BLVCK-MAMBA-6 wants to merge 5 commits into
sktime:mainfrom
BLVCK-MAMBA-6:feature/decodermlp-v2

Conversation

@BLVCK-MAMBA-6
Copy link
Copy Markdown

Summary

Closes #2076

Implements DecoderMLP for the v2 pipeline by inheriting from TslibBaseModel,
following the pattern established by DLinear in _dlinear_v2.py.

Changes

  • pytorch_forecasting/models/mlp/_decodermlp_v2.py — new v2 implementation
  • pytorch_forecasting/models/mlp/__init__.py — exports DecoderMLPV2
  • tests/test_models/test_decodermlp_v2.py — 5 tests, 85% coverage

Test results

All 5 tests passing locally:

  • test_decodermlp_init
  • test_decodermlp_forward
  • test_decodermlp_quantile_loss
  • test_decodermlp_no_nan
  • test_decodermlp_univariate

This is part of my GSoC 2026 application for Project 2.2 (v1→v2 model migration).

@codecov
Copy link
Copy Markdown

codecov Bot commented Mar 22, 2026

Codecov Report

❌ Patch coverage is 85.18519% with 8 lines in your changes missing coverage. Please review.
⚠️ Please upload report for BASE (main@5600398). Learn more about missing BASE report.

Files with missing lines Patch % Lines
pytorch_forecasting/models/mlp/_decodermlp_v2.py 84.61% 8 Missing ⚠️
Additional details and impacted files
@@           Coverage Diff           @@
##             main    #2225   +/-   ##
=======================================
  Coverage        ?   86.61%           
=======================================
  Files           ?      166           
  Lines           ?     9789           
  Branches        ?        0           
=======================================
  Hits            ?     8479           
  Misses          ?     1310           
  Partials        ?        0           
Flag Coverage Δ
cpu 86.61% <85.18%> (?)
pytest 86.61% <85.18%> (?)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Add v2 support for MLP

1 participant