[BUG] Safe fallback for retrieving index from QuantileLoss.to_prediction when 0.5 is unavailable#2256
Open
Muhammad-Rebaal wants to merge 6 commits into
Open
Conversation
…on when 0.5 is unavailable
Muhammad-Rebaal
requested review from
PranavBhatP,
benHeid,
fkiraly,
fnhirwa,
jdb78,
phoeenniixx and
yarnabrina
as code owners
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #2256 +/- ##
=======================================
Coverage ? 86.93%
=======================================
Files ? 166
Lines ? 9767
Branches ? 0
=======================================
Hits ? 8491
Misses ? 1276
Partials ? 0
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
phoeenniixx
requested changes
Apr 11, 2026
Member
phoeenniixx
left a comment
phoeenniixx
left a comment
There was a problem hiding this comment.
Thanks!
Can you please add a minimal test to make sure it is working as expected?
phoeenniixx
changed the title
QuantileLoss.to_prediction when 0.5 is unavailableQuantileLoss.to_prediction when 0.5 is unavailable
Contributor
Author
|
Hi @phoeenniixx , |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
References : #2255
Description
If a user creates an instance of
QuantileLossdefining bounding target quantiles (e.g.,[0.1, 0.9]) but excluding the direct median probability0.5, performing a.to_prediction()pass crashes parsing the output.Changes Made
if 0.5 in self.quantiles, returning exact. If absent, it establishes the minimum offset matching0.5, safely reverting to the closest approximated center. Modifiedpytorch_forecasting/metrics/quantile.py.CC : @phoeenniixx , @PranavBhatP , @fkiraly