[BUG] FIXED: Potential sequence length bug in preprocessed record (Obvious but Critical)#2266
Open
Chetansahney wants to merge 2 commits into
Open
[BUG] FIXED: Potential sequence length bug in preprocessed record (Obvious but Critical)#2266Chetansahney wants to merge 2 commits into
Chetansahney wants to merge 2 commits into
Conversation
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #2266 +/- ##
=======================================
Coverage ? 86.92%
=======================================
Files ? 166
Lines ? 9766
Branches ? 0
=======================================
Hits ? 8489
Misses ? 1277
Partials ? 0
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
Author
|
Hi @christy @rustyconover @szepeviktor @TKlerx . |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Reference Issues/PRs
Fixes #2265
What does this implement/fix? Explain your changes.
This PR fixes sequence-length metadata in tslib preprocessing.
_preprocess_data() was using len(series) (number of keys in the record) instead of the true time dimension length.
It now sets length from the timestep/sequence length, so downstream logic receives correct series length metadata.
What should a reviewer concentrate their feedback on?
Did you add any tests for the change?
Yes. Added/updated a regression assertion in test_preprocess_data to verify processed["length"] == len(original_sample["t"]).
Any other comments?
This is a targeted bugfix with minimal surface-area changes.
PR checklist