[WIP] Improve group feature of Skychat, both on features and infrastructures - #3631
Open
mrpalide wants to merge 18 commits into
Open
[WIP] Improve group feature of Skychat, both on features and infrastructures #3631mrpalide wants to merge 18 commits into
mrpalide wants to merge 18 commits into
Conversation
…silently undid evictions
…alone, so an offline founder meant nobody could join
… second admin, and a stale read-modify-Put dropped replay watermarks
…ey, so a copy of the feed kept opening
… AES key to anyone who could read the file
…toggleable per group and choosable at create time
…outrun any per-PK gate, including ban
…move DmsgVisorRPCPort off a port the visor already binds
… wraps and age/volume rotation for groups
…nts were readable on encrypted groups
…d while every message beside them was sealed
… it out from under membersMu, and -race found seven
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Did you run
make format && make check? YesFixes #_
Changes:
How to test this PR:
Browser, against three real visors:
then, across the three UIs it prints:
B lands in A's approval queue; approve it and B gets the key with the
approval, not from the link.
should visibly cost a moment (proof-of-work) rather than being instant.
new messages; A's admin panel shows the key epoch advance. Older messages
stay readable for everyone still in.
same invite link — C should be able to admit it.
header should move from "encrypted · keys not exchanged yet" to
"forward secret · key " once both sides have spoken.