SK-3002 Flowvault release/26.8.1 - #387
Merged
Merged
Conversation
…rt-using-modular-build-approach # Conflicts: # common/src/main/java/com/skyflow/utils/BaseUtils.java # pom.xml
…vault-api-support-using-modular-build-approach SK-2967 java sdk add flow db vault api support using modular build approach
…vault-api-support-using-modular-build-approach SK-2967 update the internal release
…vault-api-support-using-modular-build-approach SK-2967 update script version
…vault-api-support-using-modular-build-approach SK-2967 update internal release workflow
…vault-api-support-using-modular-build-approach SK-2967 java sdk add flow db vault api support using modular build approach
…-api-support-using-modular-build-approach
…vault-api-support-using-modular-build-approach SK-2967 fix internal release workflows
…-api-support-using-modular-build-approach
…low-db-vault-api-support-using-modular-build-approach
The Codecov step uploaded target/site/jacoco/jacoco.xml, which was correct when this repo was a single Maven module. Since the common/v2/flowvault split the root pom is <packaging>pom</packaging> with no sources, so that file is never generated - codecov received nothing and reported no coverage for the PR. Verified locally: 'mvn -B package -f pom.xml' produces reports only at common/, v2/ and flowvault/ target/site/jacoco/jacoco.xml; the root path does not exist. Same class of issue as the 'Distribute test fixtures to modules' step already added on this branch - a repo-root path left over from the single-module layout.
Every individual_component path was rooted at src/main/java/..., which was correct when this was a single Maven module. Sources now live at <module>/src/main/java/..., so all 11 component globs matched zero files and each component reported no coverage data - which is the 'no coverage reports found' seen on the PR. The uploaded report itself was fine: the Codecov API shows state 'complete' for c1c5719 with 115 files at 91.75% (v2 55, common 30, flowvault 30), correctly path-resolved. Only the component matching was broken. Prefixed each glob with **/ so components aggregate a functional area across all modules, matching the previous semantics. Quoted because a bare leading * is a YAML alias. Verified against the real file list from the Codecov API: 0 components match zero files (was 11/11).
…-changes-for-insert-and-detokenize SK-3026 internal release for insert and detokenize added according to doc
skyflow-bharti
changed the title
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Start with a concise summary of the PR. The first three sections are required. The questions present in each section is there to help you guide you what to add. They are meant to be overwritten by your comments.
Why
Goal
Testing
Tech debt